From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CE35776979 for ; Fri, 23 Apr 2021 15:31:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9405298EC for ; Fri, 23 Apr 2021 15:30:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4E7F7298DF for ; Fri, 23 Apr 2021 15:30:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1969045960 for ; Fri, 23 Apr 2021 15:30:36 +0200 (CEST) Message-ID: <9f379462-35f3-ae48-d994-2ec524a8c6a3@proxmox.com> Date: Fri, 23 Apr 2021 15:30:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox VE development discussion , Lorenz Stechauner References: <20210422074902.32118-1-l.stechauner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210422074902.32118-1-l.stechauner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.007 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] ui: set file name for spice console download in chrome X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2021 13:31:12 -0000 On 22.04.21 09:49, Lorenz Stechauner wrote: > When the virt-viewer file is downloaded we already set > a file name in Android, so the file type may be > recognized. Also doing this in Chrome (and Chromium > based browsers) allows users to "alyways open files of > this type". So the browser automatically opens the > console window without user interaction. > note, this seems like a bit of a crammed commit message text-width wise. I amended that to match the text-width = 69, as it should neither be overly long, nor really short. If you use vim for writing those I suggest adding a hunk like the following to your vimrc: au FileType gitcommit setlocal tw=69 > Signed-off-by: Lorenz Stechauner > --- > www/manager6/Utils.js | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > applied, thanks! Behavior is really better this way in Chrome/Chromium. My Firefox here already worked fine, so seems not required for it anyway.