From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0824691CFF for ; Mon, 10 Oct 2022 10:46:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D753A15A5 for ; Mon, 10 Oct 2022 10:45:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 10 Oct 2022 10:45:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EF1B444900 for ; Mon, 10 Oct 2022 10:45:47 +0200 (CEST) Message-ID: <9efc06ed-91ed-1f32-4d07-86b16a48052a@proxmox.com> Date: Mon, 10 Oct 2022 10:45:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20221007084458.1242670-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221007084458.1242670-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH novnc] don't show error messages for users without VM.Audit privileges X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2022 08:46:20 -0000 Am 07/10/2022 um 10:44 schrieb Dominik Csapak: > we now query the guest status before starting, but that requires VM.Audit > privileges, which are not necessary since only VM.Console is actually > required to connect to the console. > > In that case, skip the error message and continue connecting > > reported in the forum: > https://forum.proxmox.com/threads/vm-console-require-vm-audit.116176/ > > Signed-off-by: Dominik Csapak > --- > ...ow-start-button-on-not-running-vm-ct.patch | 26 ++++++++++++++----- > 1 file changed, 20 insertions(+), 6 deletions(-) > > applied, but reworked commit message for more context (or maybe better said, reword it such that it's a bit clearer why/what/how) and to avoid sounding a bit like that this is a front end solution for a issue where we allowed to query the guest status if only VM.Console was present, thanks!