From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id BAAEE6AB5A
 for <pve-devel@lists.proxmox.com>; Mon, 15 Mar 2021 14:42:08 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id AB73E222A1
 for <pve-devel@lists.proxmox.com>; Mon, 15 Mar 2021 14:42:08 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 3FF3E22294
 for <pve-devel@lists.proxmox.com>; Mon, 15 Mar 2021 14:42:08 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0A46142660
 for <pve-devel@lists.proxmox.com>; Mon, 15 Mar 2021 14:42:08 +0100 (CET)
Message-ID: <9ec06bf9-47d9-f656-f28a-203f711aca22@proxmox.com>
Date: Mon, 15 Mar 2021 14:42:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101
 Thunderbird/87.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Fabian Ebner <f.ebner@proxmox.com>
References: <20210311102650.6730-1-f.ebner@proxmox.com>
 <20210311102650.6730-6-f.ebner@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20210311102650.6730-6-f.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.048 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [RFC/PATCH v2 container 5/5] vmstatus: make
 lock property optional again
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 15 Mar 2021 13:42:08 -0000

On 11.03.21 11:26, Fabian Ebner wrote:
> Commit d02262048cbbe91ca8b12f98e3dc7bbab28e4c64 made the property de-facto
> non-optional. Partially revert this and instead adapt the printing, making the
> behavior match the API description again. The conditional assignment is
> already there further down the vmstatus function.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> New in v2.
> 
> Alternatively, the property description should be updated, but this patch makes
> it in line with what we do for VMs and is preferable IMHO.
> 

The schema is what our ABI is, so if that stated this is optional we can make
it so.

>  src/PVE/CLI/pct.pm | 3 ++-
>  src/PVE/LXC.pm     | 1 -
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!