From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A4E0B72A04 for ; Fri, 2 Jul 2021 15:43:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F41B9FEE for ; Fri, 2 Jul 2021 15:43:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0BCA59FE0 for ; Fri, 2 Jul 2021 15:43:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D7F8040552 for ; Fri, 2 Jul 2021 15:43:56 +0200 (CEST) Message-ID: <9e1be71a-ac9a-ebf4-baa1-959253286503@proxmox.com> Date: Fri, 2 Jul 2021 15:43:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210702104859.3515832-1-d.csapak@proxmox.com> <20210702104859.3515832-2-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210702104859.3515832-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.542 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH widget-toolkit 2/2] node/APTRepositories: rework top status and error grid X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2021 13:43:57 -0000 On 02.07.21 12:48, Dominik Csapak wrote: > instead of having a title bar and a seperate error grid, > add an always visible panel that displays the status (ok, warning, errors) > which also contains the error grid (if necessary, ala ceph summary) > > this makes the panel more consistent to use and it is immediatly > visible if something is wrong > > this also adds a test for the 'test' repositories, as well as a test > for not correctly configured suites > > Signed-off-by: Dominik Csapak > --- > we should probably only emit a warning for suites for Proxmox and Debian > origin, since other vendors may use different suites for their packages > (e.g. google ships all chrome debs in the 'stable' suite) > > src/node/APTRepositories.js | 147 ++++++++++++++++++++++++------------ > 1 file changed, 98 insertions(+), 49 deletions(-) > > applied, thanks!