From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 40CB11FF16E
	for <inbox@lore.proxmox.com>; Tue, 29 Oct 2024 14:18:00 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 14D9036F1F;
	Tue, 29 Oct 2024 14:18:02 +0100 (CET)
Message-ID: <9ddd8807-5623-484f-aa5d-b751d732ae53@proxmox.com>
Date: Tue, 29 Oct 2024 14:17:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Christoph Heiss <c.heiss@proxmox.com>
References: <20241022101941.329529-1-c.heiss@proxmox.com>
 <20241022101941.329529-3-c.heiss@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <20241022101941.329529-3-c.heiss@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.037 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH docs 2/3] pci-passthrough: mention that
 `intel_iommu=on` is the default for 6.8+
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Looking at the surrounding context, I would rework this section even 
more. Before I just apply my approach, what do you think about the 
following change?
---
diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
index 4f19f2a..ca07692 100644
--- a/qm-pci-passthrough.adoc
+++ b/qm-pci-passthrough.adoc
@@ -63,19 +63,18 @@ some configuration to enable PCI(e) passthrough.

  .IOMMU

-First, you will have to enable IOMMU support in your BIOS/UEFI. Usually the
+You will have to enable IOMMU support in your BIOS/UEFI. Usually the
  corresponding setting is called `IOMMU` or `VT-d`, but you should find 
the exact
  option name in the manual of your motherboard.

-For Intel CPUs, you also need to enable the IOMMU on the
-xref:sysboot_edit_kernel_cmdline[kernel command line] kernels by adding:
+With recent kernels (6.8 or newer), `IOMMU` should be enabled 
automatically.
+On older kernels, it was necessary to enable it on Intel CPUs via the
+xref:sysboot_edit_kernel_cmdline[kernel command line] by adding:

  ----
   intel_iommu=on
  ----

-For AMD CPUs it should be enabled automatically.
-
  .IOMMU Passthrough Mode

  If your hardware supports IOMMU passthrough mode, enabling this mode might



On  2024-10-22  12:19, Christoph Heiss wrote:
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>   qm-pci-passthrough.adoc | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
> index c3dd184..70e33f2 100644
> --- a/qm-pci-passthrough.adoc
> +++ b/qm-pci-passthrough.adoc
> @@ -74,7 +74,8 @@ xref:sysboot_edit_kernel_cmdline[kernel command line] kernels by adding:
>    intel_iommu=on
>   ----
>   
> -For AMD CPUs it should be enabled automatically.
> +For AMD CPUs it should be enabled automatically. For Intel CPUs this is also
> +the default since the 6.8 kernel series.
>   
>   .IOMMU Passthrough Mode
>   



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel