From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AE6EF6BC63 for ; Mon, 14 Dec 2020 12:53:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9DDF215B27 for ; Mon, 14 Dec 2020 12:52:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DC28115B1C for ; Mon, 14 Dec 2020 12:52:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ABFC5450C6 for ; Mon, 14 Dec 2020 12:52:36 +0100 (CET) To: Proxmox VE development discussion , =?UTF-8?Q?Dominic_J=c3=a4ger?= References: <20201214102052.76711-1-d.jaeger@proxmox.com> From: Thomas Lamprecht Message-ID: <9dbd3c98-1413-23f3-b571-bf393e46140d@proxmox.com> Date: Mon, 14 Dec 2020 12:52:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <20201214102052.76711-1-d.jaeger@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.318 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-common] JSONSchema: Increase vmid option minimum to 100 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2020 11:53:07 -0000 On 14.12.20 11:20, Dominic J=C3=A4ger wrote: > The API standard_option pve-vmid always checks the format pve-vmid. The= format > pve-vmid requires the vmid to be >=3D100. This is correct, because IDs = 1-99 are > reserved. >=20 > To display this correctly in the API documentation (API viewer, qm man = pages), > we have to set the minimum to 100 in the API standard_option. >=20 > Signed-off-by: Dominic J=C3=A4ger > --- > https://forum.proxmox.com/threads/qm-importovf-man-page.80632/ IIRC, we use this somewhere, albeit I'm currently not remembering where. In any case, both Dietmar and I have the feeling that this will break som= e things. I'd like to avoid that, maybe you could take another look if you = find some case where values <100 are used for some special handling? >=20 > src/PVE/JSONSchema.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm > index 29ada5b..b4596d3 100644 > --- a/src/PVE/JSONSchema.pm > +++ b/src/PVE/JSONSchema.pm > @@ -58,7 +58,7 @@ sub get_standard_option { > register_standard_option('pve-vmid', { > description =3D> "The (unique) ID of the VM.", > type =3D> 'integer', format =3D> 'pve-vmid', > - minimum =3D> 1 > + minimum =3D> 100, > }); > =20 > register_standard_option('pve-node', { >=20