From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3FF5F7D289 for ; Mon, 8 Nov 2021 15:14:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2DCC526F1C for ; Mon, 8 Nov 2021 15:14:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2DA0026F0D for ; Mon, 8 Nov 2021 15:14:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EDCB242160 for ; Mon, 8 Nov 2021 15:14:13 +0100 (CET) Message-ID: <9d591837-6bff-ce61-e5dd-e1a01561f547@proxmox.com> Date: Mon, 8 Nov 2021 15:14:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20211108134400.1884660-1-o.bektas@proxmox.com> <20211108134400.1884660-3-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211108134400.1884660-3-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.178 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.039 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH lxc 2/2] include common.conf in openwrt configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 14:14:46 -0000 On 08.11.21 14:44, Oguz Bektas wrote: > necessary for the container to start, otherwise we get stuck in creating > /dev directory. why though and what from common settings actually helps would be good to clarify in such patches.. FWIW, the conf seems very outdated, e.g., lxc tty dirs do not matter much nowadays IIRC, I'd rather revise/update them a bit more in-depth *after* the next releases. > > Signed-off-by: Oguz Bektas > --- > config/openwrt.common.conf.in | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/config/openwrt.common.conf.in b/config/openwrt.common.conf.in > index 73db6f6..aa2e332 100644 > --- a/config/openwrt.common.conf.in > +++ b/config/openwrt.common.conf.in > @@ -1,3 +1,6 @@ > +# This derives from the global common config. > +lxc.include = @LXCTEMPLATECONFIG@/common.conf > + > # Default console settings > lxc.tty.dir = lxc > lxc.tty.max = 4 >