From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BF3017627F for ; Thu, 15 Jul 2021 09:48:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE0701B7D2 for ; Thu, 15 Jul 2021 09:48:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2AD841B7C3 for ; Thu, 15 Jul 2021 09:48:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E6A2D4100D for ; Thu, 15 Jul 2021 09:48:05 +0200 (CEST) To: pve-devel@lists.proxmox.com References: <20210715065126.11237-1-f.ebner@proxmox.com> From: Fabian Ebner Message-ID: <9c994ff9-e316-99ae-c77a-df75313f663b@proxmox.com> Date: Thu, 15 Jul 2021 09:48:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210715065126.11237-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.348 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [apt.pm] Subject: Re: [pve-devel] [PATCH v2 manager] api: apt: repos: fix interfacing with perlmod X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 07:48:36 -0000 Am 15.07.21 um 08:51 schrieb Fabian Ebner: > Using > pvesh create /nodes/pve701/apt/repositories --path > "/etc/apt/sources.list" --index 0 --enabled 1 > reliably leads to > error: invalid type: string "0", expected usize > > Coerce to int to avoid this. I was not able to trigger the issue with > the "enabled" option here (in PMG I was), but be on the safe side and > coerce there too. > > Signed-off-by: Fabian Ebner > --- > > Added the v2 in the subject this time, sorry. > > Changes from v1: > * avoid creating an implicit default by checking definedness first > > PVE/API2/APT.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm > index bd60db33..310d875f 100644 > --- a/PVE/API2/APT.pm > +++ b/PVE/API2/APT.pm > @@ -750,13 +750,16 @@ __PACKAGE__->register_method({ > code => sub { > my ($param) = @_; > > + my $enabled = $param->{enabled}; > + $enabled = int($enabled) if defined($enabled); > + > my $options = { > - enabled => $param->{enabled}, > + enabled => $enabled, > }; > > PVE::RS::APT::Repositories::change_repository( > $param->{path}, > - $param->{index}, > + int($param->{index}), > $options, > $param->{digest} > ); > This still doesn't work reliably for some reason, but it's very strange: Seems like when enabled is not passed as a parameter, it's sometimes interpreted as Some(false) even if it's undef in Perl. I was not able to trigger it with pvesh, only when sending the requests via Firefox dev tools.