From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8EB2660497 for ; Wed, 12 Aug 2020 10:38:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 84F0AE85E for ; Wed, 12 Aug 2020 10:38:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B6ACEE852 for ; Wed, 12 Aug 2020 10:38:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 82A5E445BA for ; Wed, 12 Aug 2020 10:38:34 +0200 (CEST) To: pve-devel@lists.proxmox.com References: <20200804113244.26810-1-f.ebner@proxmox.com> <1597149316.pyafbcpqc0.astroid@nora.none> From: Fabian Ebner Message-ID: <9c5098f7-ce12-c90e-b4d5-d0d62854c2e7@proxmox.com> Date: Wed, 12 Aug 2020 10:38:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1597149316.pyafbcpqc0.astroid@nora.none> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.407 Adjusted score from AWL reputation of From: address KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemuserver.pm] Subject: Re: [pve-devel] [PATCH qemu-server 1/2] Fix #2816: increase timeout for allocation on restore X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Aug 2020 08:38:36 -0000 Am 11.08.20 um 14:36 schrieb Fabian Grünbichler: > On August 4, 2020 1:32 pm, Fabian Ebner wrote: >> qcow2 images are allocated with --preallocation=metadata, >> which can take a while for large images. >> Avoid using 'got timeout' as an error message by itself, >> to make it clearer where a timeout occured. >> >> Signed-off-by: Fabian Ebner >> --- >> PVE/QemuServer.pm | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm >> index 0a09f3a..8b0b2c8 100644 >> --- a/PVE/QemuServer.pm >> +++ b/PVE/QemuServer.pm >> @@ -6261,7 +6261,7 @@ sub restore_vma_archive { >> local $SIG{QUIT} = >> local $SIG{HUP} = >> local $SIG{PIPE} = sub { die "interrupted by signal\n"; }; >> - local $SIG{ALRM} = sub { die "got timeout\n"; }; >> + local $SIG{ALRM} = sub { die "got timeout preparing device images\n"; }; >> >> $oldtimeout = alarm($timeout); ^[0] >> >> @@ -6275,9 +6275,9 @@ sub restore_vma_archive { >> $devinfo->{$devname} = { size => $size, dev_id => $dev_id }; >> } elsif ($line =~ m/^CTIME: /) { >> # we correctly received the vma config, so we can disable >> - # the timeout now for disk allocation (set to 10 minutes, so >> + # the timeout now for disk allocation (set to 1 hour, so >> # that we always timeout if something goes wrong) > > do we really need this timeout? we are by definition in a worker > already, instead of moving the goal post once more could we not drop > this and let the user hit 'Stop' if the allocation stalls altogether? > I thought we'd need the timeout here, because otherwise the timeout from above[0] is still active. This also seems to be the reason the timeout was introduced in the first place with 3cf90d7a40554b4c353e389209d6ef36a89b96a7 But of course we could move the alarm($oldtimeout || 0) to before &$print_devmap(). If we do this, then the time spent allocating the disks will eat into the oldtimeout. That said, oldtimeout should always be 0 anyways, because AFAICT the only path leading here is: API-create_vm -> *spawning of worker* -> restore_file_archive -> restore_vma_archive and nobody sets an alarm along the way. I'll send a v2. >> - alarm(600); >> + alarm(60 * 60); >> &$print_devmap(); >> print $fifofh "done\n"; >> my $tmp = $oldtimeout || 0; >> -- >> 2.20.1 >> >> >> >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >> >> >> > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >