From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9422F1FF183 for ; Wed, 27 Aug 2025 09:32:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 45C0411EC4; Wed, 27 Aug 2025 09:32:23 +0200 (CEST) Message-ID: <9be0c0ba-b50c-4b8a-9832-440328d6d55c@proxmox.com> Date: Wed, 27 Aug 2025 09:31:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Thomas Skinner , Daniel Kral References: <20250825041128.132814-1-thomas@atskinner.net> <20250825041128.132814-5-thomas@atskinner.net> Content-Language: de-DE, en-US From: Thomas Lamprecht In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756279904069 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.179 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH ha-manager 2/2] add api getter/setter for node maintenance mode X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 26/08/2025 18:02, Thomas Skinner wrote: >> The more I think about it, I'm somewhat inclined to register the whole >> subclass under /nodes/{node}/ha/... instead of /cluster/ha/nodes/... to >> not duplicate the information of a nodelist, which is provided by >> pve-cluster and there would be something wrong with the HA Manager >> anyway if those are out-of-sync and all the HA-related information can >> then live in a node-specific "ha" subdirectory. >> >> Then this API handler wouldn't be needed anymore at all. > If this is how Proxmox would like it, that makes it much easier IMO. I > wasn't sure which one to include it under, so I put it under the > cluster path since a cluster must be created to even have the HA > featureset. I'm good with either, I just need to know so that I know > what to update for a v2 series. We might be already all on the same page, so just to be sure and a bit more context to avoid making this to HA specific: Reporting the current (maintenance) status should go into either (or both of) the /cluster/ha/status and/or the /cluster/resources API endpoint. As there are some light-weight plans to provide maintenance mode for non-ha services, I'd indeed place that outside of a ha specific path now already, might be even fine to use a dedicated /nodes/{node}/maintenance API endpoint. For now the description should state that it's only affecting HA, the non-HA parts are probably not very complicated work, but got quite a few edge cases and design decisions that are better done in a separate series building on top of such API infrastructure you add here. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel