From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0E4091FF0B4 for ; Tue, 10 Nov 2026 13:09:49 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4E8F6215FC; Tue, 10 Nov 2026 13:09:45 +0100 (CET) Message-ID: <9bacc7c5-d0ba-45a4-9b81-8da9c3de22ff@proxmox.com> Date: Tue, 10 Nov 2026 13:09:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] fix #8292: ui: node: StatusView: do not mutate the class-level items array To: =?UTF-8?Q?Rapha=C3=ABl_Flores?= , pve-devel@lists.proxmox.com References: <0c0f6a2b-b475-4f41-9342-c0d4ae94becc@inrae.fr> <9f4c7322-016f-4563-9365-023753718930@proxmox.com> <58d748c6-e255-4ce5-9249-4c8c080ce9c5@inrae.fr> Content-Language: en-US From: Dominik Csapak In-Reply-To: <58d748c6-e255-4ce5-9249-4c8c080ce9c5@inrae.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794312579051 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.315 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IKUXKLLHZ7ZHNKAUZPF7HIML7HBC7TEA X-Message-ID-Hash: IKUXKLLHZ7ZHNKAUZPF7HIML7HBC7TEA X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/9/26 3:06 PM, Raphaël Flores wrote: > Hi Dominik, Hi, > > thanks for the quick review. > > I've read the Developer Documentation and have sent the signed > Contributor License Agreement to office@proxmox.com. thanks for confirmation. I did try to apply the patch, but `git am` wouldn't let me, probably because of the post diff message or footer. Normally comments go after the '---' after the commit message before the actual diff (i marked the part inline) would you mind sending the patch again with the comment (re)moved ? If you want i can commit the changes under my name if you don't want to send it again. > Best regards, > Raphaël Flores > Best regards Dominik > Le 05/11/2026 à 13:26, Dominik Csapak a écrit : >> Hi, >> >> thanks for your contribution >> >> The patch itself looks good, but did you see >> https://pve.proxmox.com/wiki/Developer_Documentation ? >> >> especially the part about signing a CLA? >> >> We'd need that before we apply patches of yours. >> >> best regards >> Dominik >> >> On 11/5/26 12:44 PM, Raphaël Flores wrote: >>> The repository status widget is appended to `items` in initComponent, >>> but >>> `items` is declared at class level, so every instance of >>> PVE.node.StatusView >>> receives the very same array. Each instantiation therefore left one more >>> config object in that shared array: the k-th display of a node's >>> Summary page >>> constructed k pmxNodeInfoRepoStatus widgets instead of one, and all >>> but one of >>> them were never destroyed (they stay registered in >>> Ext.ComponentManager, with >>> no DOM node, and are not freed by the cycle collector). >>> >>> The node view is rebuilt on every display of the summary panel, so >>> the waste >>> grows quadratically with navigation: 322 displays left 52 004 live >>> widget >>> instances and 208 322 ExtJS components behind, while the DOM stayed >>> flat. >>> >>> Build a per-instance array instead of pushing onto the shared one. >>> >>> Signed-off-by: Raphaël Flores >>> --- here is where a comment would go >>>   www/manager6/node/StatusView.js | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/ >>> StatusView.js >>> index 0046f5d5..08d68a95 100644 >>> --- a/www/manager6/node/StatusView.js >>> +++ b/www/manager6/node/StatusView.js >>> @@ -157,7 +157,7 @@ Ext.define('PVE.node.StatusView', { >>>               nodetab: 'aptrepositories', >>>           }); >>> >>> -        me.items.push({ >>> +        me.items = me.items.concat({ >>>               xtype: 'pmxNodeInfoRepoStatus', >>>               itemId: 'repositoryStatus', >>>               product: 'Proxmox VE', >> >> >> >> >> >>