From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 739AE7842F for ; Thu, 29 Apr 2021 16:58:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C35C1F97F for ; Thu, 29 Apr 2021 16:58:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DABAD1F971 for ; Thu, 29 Apr 2021 16:58:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8612E464A1 for ; Thu, 29 Apr 2021 16:58:01 +0200 (CEST) Message-ID: <9b82103e-e5e9-9544-fc2f-6f486fadd734@proxmox.com> Date: Thu, 29 Apr 2021 16:57:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox VE development discussion , Hannes Laimer References: <20200911100816.80543-1-h.laimer@proxmox.com> <20200911100816.80543-3-h.laimer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20200911100816.80543-3-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [network.pm] Subject: Re: [pve-devel] [PATCH v1 pve-common 2/5] add out/in-rate parameter to tap_plug sub, keep version with just rate param X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 14:58:32 -0000 On 11.09.20 12:08, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > src/PVE/Network.pm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm > index 3e7a1c1..3b09cec 100644 > --- a/src/PVE/Network.pm > +++ b/src/PVE/Network.pm > @@ -389,6 +389,11 @@ my $cleanup_firewall_bridge = sub { > > sub tap_plug { > my ($iface, $bridge, $tag, $firewall, $trunks, $rate) = @_; > + tap_plug($iface, $bridge, $tag, $firewall, $trunks, $rate, $rate); > +} > + > +sub tap_plug { > + my ($iface, $bridge, $tag, $firewall, $trunks, $inrate, $outrate) = @_; FYI: This really cannot work, perl has no such overloading. In theory you could pass the $in/out as array ref or even hash and check for that. Something like the following (not tested): my ($iface, $bridge, $tag, $firewall, $trunks, $rate) = @_; my ($inrate, $outrate); if (defined($rate) && ref($rate) eq 'HASH) { ($inrate, $outrate) = $rate->@{'in', 'out'}; } else { $inrate = $outrate = $rate; } > > #cleanup old port config from any openvswitch bridge > eval {run_command("/usr/bin/ovs-vsctl del-port $iface", outfunc => sub {}, errfunc => sub {}) }; > @@ -422,7 +427,7 @@ sub tap_plug { > } > } > > - tap_rate_limit($iface, $rate); > + tap_rate_limit($iface, $outrate, $inrate); > } > > sub tap_unplug { >