From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 12DCF62E65 for ; Thu, 1 Oct 2020 17:23:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F155622E6A for ; Thu, 1 Oct 2020 17:22:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D1B8622E5B for ; Thu, 1 Oct 2020 17:22:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A442F45B9F for ; Thu, 1 Oct 2020 17:22:48 +0200 (CEST) To: Thomas Lamprecht , Proxmox VE development discussion References: <20201001121840.23081-1-a.lauterer@proxmox.com> <8a9a3acc-2552-5fe5-8f6b-11a9e4b28abc@proxmox.com> From: Aaron Lauterer Message-ID: <9ad242f9-73be-4f64-99d1-37f4689009a9@proxmox.com> Date: Thu, 1 Oct 2020 17:22:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <8a9a3acc-2552-5fe5-8f6b-11a9e4b28abc@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: FirewallRules.js: fix #3049 wider rule number column X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 15:23:20 -0000 On 10/1/20 5:10 PM, Thomas Lamprecht wrote: > On 01.10.20 14:18, Aaron Lauterer wrote: >> Allows 2 digits rule numbers to be visible in the column. Made it a bit >> wider than needed to account for potentially wider font rendering on >> different platforms. >> >> Signed-off-by: Aaron Lauterer >> --- >> www/manager6/grid/FirewallRules.js | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js >> index ec2d1c84..42035129 100644 >> --- a/www/manager6/grid/FirewallRules.js >> +++ b/www/manager6/grid/FirewallRules.js >> @@ -629,7 +629,7 @@ Ext.define('PVE.FirewallRules', { >> // similar to xtype: 'rownumberer', >> dataIndex: 'pos', >> resizable: false, >> - width: 23, >> + width: 42, >> sortable: false, >> align: 'right', >> hideable: false, >> > > oh, and maybe you can try to switch that whole column definition away from fixed > widths to relative "flex" only. Just needs to look OK on 720p and quite good on > 1080p. It's not always possible, but most of the time it works out well and not > using fixed widths is always nicer, IMO. > good point. I'll take a look at it.