From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 04CE568C8F for ; Thu, 10 Mar 2022 13:02:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E99E919FEB for ; Thu, 10 Mar 2022 13:01:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6C0EB19FDF for ; Thu, 10 Mar 2022 13:01:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B143463BD for ; Thu, 10 Mar 2022 13:01:50 +0100 (CET) Message-ID: <99d70393-8e7d-e44b-277b-36879906cd3f@proxmox.com> Date: Thu, 10 Mar 2022 13:01:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, Oguz Bektas References: <20220307092043.571640-1-o.bektas@proxmox.com> <20220307092043.571640-2-o.bektas@proxmox.com> From: Fabian Ebner In-Reply-To: <20220307092043.571640-2-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.124 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [restenvironment.pm] Subject: Re: [pve-devel] [PATCH common 2/2] REST environment: default to 'root@pam' for forked workers in case no user was specified X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 12:02:21 -0000 Am 07.03.22 um 10:20 schrieb Oguz Bektas: > previously we had a default of 'root@pve', which doesn't exist. > since the username is only relevant for the task logs, we can change it > to 'root@pam' without ill effects. > > also add a warning in case there are other call sites that we missed > where fork_worker is called without a user variable (found call sites > only in pve-container where this was unset, namely in 'push_file' and > 'pull_file'). > > Signed-off-by: Oguz Bektas > --- > src/PVE/RESTEnvironment.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm > index 1b2af08..5352aad 100644 > --- a/src/PVE/RESTEnvironment.pm > +++ b/src/PVE/RESTEnvironment.pm > @@ -492,7 +492,10 @@ sub fork_worker { > $dtype = 'unknown' if !defined ($dtype); > $id = '' if !defined ($id); > > - $user = 'root@pve' if !defined ($user); It'd be a bit cleaner to default to $self->get_user(1) first and only if that's not set to something else. Maybe the warning is only needed in the latter case. Would also make the first patch unnecessary, although it doesn't hurt of course. > + if (!defined($user)) { > + warn 'Worker user was not specified, defaulting to "root@pam"!'; Could mention that it's an internal error. And could use $self->warn(). > + $user = 'root@pam'; > + } > > my $sync = ($self->{type} eq 'cli' && !$background) ? 1 : 0; >