From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AECAE74BD4 for ; Thu, 2 Jun 2022 09:07:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A4BEA2708E for ; Thu, 2 Jun 2022 09:07:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 332A227082 for ; Thu, 2 Jun 2022 09:07:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0112042A48 for ; Thu, 2 Jun 2022 09:07:23 +0200 (CEST) Message-ID: <99b6d70c-d164-5457-4f91-cd27d4c2f25c@proxmox.com> Date: Thu, 2 Jun 2022 09:07:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20220601102321.4093592-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220601102321.4093592-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.297 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.575 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager/docs] handle missed jobs better X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2022 07:07:23 -0000 Am 01/06/2022 um 12:23 schrieb Dominik Csapak: > by adding a config option 'skip-missed' for jobs that skips the jobs > on pvescheduler start and when changing from disabled -> enabled > > i did not use the systemd name 'persistent' since the name does > not really convey what it means, so i tried to come up with > a better name for it (the logic is just reversed from the systemd > variant, and our default is 0) > for the record the off list exchange: * skipping immediate "catch up" run on disable->enable change should be unconditionally off * "skip-missed" is somewhat double negative, rather negate that and use "persistent", like systemd does, or "repeat-missed" * the behaviour should then be off by default to avoid triggering lots of backups during boot up. * I'd move the box into advanced section in the gui