From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ED8ABA1941 for ; Thu, 15 Jun 2023 14:56:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C1B9927287 for ; Thu, 15 Jun 2023 14:56:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 15 Jun 2023 14:56:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B2D4145844 for ; Thu, 15 Jun 2023 14:56:06 +0200 (CEST) Message-ID: <991191ad-d23a-cbda-8b2b-644cf27db43e@proxmox.com> Date: Thu, 15 Jun 2023 14:56:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox VE development discussion , Noel Ullreich References: <20230615120329.28764-1-n.ullreich@proxmox.com> From: Markus Frank In-Reply-To: <20230615120329.28764-1-n.ullreich@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.098 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nfsplugin.pm, dirplugin.pm, cifsplugin.pm, glusterfsplugin.pm, cephfsplugin.pm, pluggin.pm, storage.pm, proxmox.com, plugin.pm] Subject: Re: [pve-devel] [PATCH pve-storage/pve-manager v3 0/4] fix #623: show isos/vztmpl/snippets in subdirs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2023 12:56:08 -0000 Works fine. Seems to be a good addition for organizing ISOs, vztmpl, etc. You could add a selector for a directory or a "destination path" text-input to the file upload as a follow-up patch. Tested-by: Markus Frank On 6/15/23 14:03, Noel Ullreich wrote: > This patch fixes #623, allowing isos/vztmpl/snippets in subdirectories. > This feature is opt-in and can be set from the API, web interface or > with `pvesm`. > > I addressed the security concerns raised by Fabian, now parent > directories in the path (i.e. `/my/path/../somewhere/`) are forbidded. > I have kept the permission to use symlinks, however, if this is a > security issue, symlinks can easily be forbidden as well. This, > however, would be a breaking change. > > parts of the tests as well as the regex for checking, if a `/../` is in > the path have been taken and/or adapted from an older patch that was > never merged: > https://lists.proxmox.com/pipermail/pve-devel/2020-May/043622.html > > This is a complete rework from v1, so I don't see a point in writing > what the differences are. It's all different. > > ---- > changes from v2: > * rebased so that applying with new structure in pve-storage works > (/PVE was moved to /src/PVE/) > * fixed the path of the volid for snippets in Pluggin.pm (thanks @Markus) > > Noel Ullreich (4): > > pve-storage: > recursively go through subdirs to find files > add `subdir-depth` option to filesystems > update test for recursive subdir search > > src/PVE/Storage.pm | 7 +++ > src/PVE/Storage/CIFSPlugin.pm | 1 + > src/PVE/Storage/CephFSPlugin.pm | 1 + > src/PVE/Storage/DirPlugin.pm | 1 + > src/PVE/Storage/GlusterfsPlugin.pm | 1 + > src/PVE/Storage/NFSPlugin.pm | 1 + > src/PVE/Storage/Plugin.pm | 63 +++++++++++++++++---------- > src/test/filesystem_path_test.pm | 18 ++++++++ > src/test/list_volumes_test.pm | 68 ++++++++++++++++++++++++++++++ > src/test/parse_volname_test.pm | 40 ++++++++++++++++++ > 10 files changed, 179 insertions(+), 22 deletions(-) > > pve-manager: > www/manager6/storage/Base.js | 11 +++++++++++ > 1 file changed, 11 insertions(+)