From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DBB89763FE for ; Thu, 15 Jul 2021 14:36:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8653232F0 for ; Thu, 15 Jul 2021 14:36:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 39294232E2 for ; Thu, 15 Jul 2021 14:36:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0515441C3E for ; Thu, 15 Jul 2021 14:36:28 +0200 (CEST) Message-ID: <99111886-b2ee-788e-0618-665348e8bb6d@proxmox.com> Date: Thu, 15 Jul 2021 14:36:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210714125258.1747811-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210714125258.1747811-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.439 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2 1/3] ui: add Schema singleton X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 12:36:28 -0000 On 14.07.21 14:52, Dominik Csapak wrote: > and override the Proxmox.Schema.authDomains in its constructor > > Signed-off-by: Dominik Csapak > --- > new in v2 > IMO the patch order is a bit weird as we add the overrides here already but remove the existing ones only in the second one, rather I'd either: * squash patch 1 and patch 2 * really only add the schema boilerplate in patch 1 Besides that it would then also be good to move the storage schema and possible other such things over to the new module, else we have two places with that stuff, which is not really nice (and can be confusing for people adding the next schema). > www/manager6/Makefile | 1 + > www/manager6/Schema.js | 53 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+) > create mode 100644 www/manager6/Schema.js > > diff --git a/www/manager6/Makefile b/www/manager6/Makefile > index 75d355a5..0b0d833e 100644 > --- a/www/manager6/Makefile > +++ b/www/manager6/Makefile > @@ -4,6 +4,7 @@ JSSRC= \ > Parser.js \ > StateProvider.js \ > Utils.js \ > + Schema.js \ > Toolkit.js \ > VNCConsole.js \ > button/ConsoleButton.js \ > diff --git a/www/manager6/Schema.js b/www/manager6/Schema.js > new file mode 100644 > index 00000000..4e8ca8b9 > --- /dev/null > +++ b/www/manager6/Schema.js > @@ -0,0 +1,53 @@ > +Ext.define('PVE.Schema', { // a singleton > + singleton: true, > + > + constructor: function() { > + var me = this; > + > + > + Proxmox.Schema.overrideAuthDomains({ > + ad: { > + name: gettext('Active Directory Server'), > + ipanel: 'pveAuthADPanel', > + syncipanel: 'pveAuthLDAPSyncPanel', > + add: true, > + edit: true, > + tfa: true, > + pwchange: true, > + }, > + ldap: { > + name: gettext('LDAP Server'), > + ipanel: 'pveAuthLDAPPanel', > + syncipanel: 'pveAuthLDAPSyncPanel', > + add: true, > + edit: true, > + tfa: true, > + pwchange: true, > + }, > + openid: { > + name: gettext('OpenID Connect Server'), > + ipanel: 'pveAuthOpenIDPanel', > + add: true, > + edit: true, > + tfa: false, > + pwchange: false, > + iconCls: 'pmx-itype-icon-openid-logo', > + }, > + pam: { > + name: 'Linux PAM', > + ipanel: 'pveAuthBasePanel', > + add: false, > + edit: true, > + tfa: true, > + pwchange: true, > + }, > + pve: { > + name: 'Proxmox VE authentication server', > + ipanel: 'pveAuthBasePanel', > + add: false, > + edit: true, > + pwchange: true, > + }, > + }); > + }, > +}); >