From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 56B8EF569
 for <pve-devel@lists.proxmox.com>; Fri, 21 Jul 2023 15:54:41 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 32B521FCC6
 for <pve-devel@lists.proxmox.com>; Fri, 21 Jul 2023 15:54:11 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Fri, 21 Jul 2023 15:54:10 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8511C426A8
 for <pve-devel@lists.proxmox.com>; Fri, 21 Jul 2023 15:54:10 +0200 (CEST)
Message-ID: <98eae5be-5676-4d6f-b6e5-2c454262edba@proxmox.com>
Date: Fri, 21 Jul 2023 15:54:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-GB
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Lukas Wagner <l.wagner@proxmox.com>
References: <20230721093910.254158-1-l.wagner@proxmox.com>
 <20230721093910.254158-3-l.wagner@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20230721093910.254158-3-l.wagner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.076 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pve-devel] [PATCH manager 3/3] headerbar: center search box,
 make it adapt to the width of the browser
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 21 Jul 2023 13:54:41 -0000

unsure about this, need to think a bit and as a few other things
are pending and some vacation too I'd say let's revisit in September
(i.e., ping me then please) if I didn't get around to it.

On 21/07/2023 11:39, Lukas Wagner wrote:
> Also adding a minWidth/maxWidth so that it doesn't become comically
> large or small. The minimum size is roughly the same size as the

you can use numbers here, IMO 168 px and 200 px is not roughly the
same ^^

> search bar was before. The maxmium size is the same size as the
> results grid, making them align nicely.

Would be centering the search result grid then be good to? Also,
making it bigger if viewport size allows it, e.g. due to having more
stuff like the tags shown in there nowadays.

Also, we predominantly use integer flex values, besides consistency
one IMO has a better ration understanding there.