From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 561F81FF16E for <inbox@lore.proxmox.com>; Mon, 31 Mar 2025 16:06:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 69FF47B69; Mon, 31 Mar 2025 16:06:35 +0200 (CEST) Message-ID: <98e98859-bbca-4e34-b1a4-ddd736324763@proxmox.com> Date: Mon, 31 Mar 2025 16:06:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20250326152608.46560-1-d.csapak@proxmox.com> Content-Language: en-US From: Filip Schauer <f.schauer@proxmox.com> In-Reply-To: <20250326152608.46560-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage/manager v4] allow down/upload & import of images in the web UI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Tested with (.img.raw/.raw), .qcow2, .vmdk and different combinations of target storages/formats. Everything worked fine except for one thing: The upload dialog allows the user to manually change the file name. When changing the file extension to ".img". Clicking "Upload" is allowed but after the upload completes, the following error is thrown: ``` Error 400: Parameter verification failed. filename: invalid filename or wrong extension ``` On 26/03/2025 16:26, Dominik Csapak wrote: > most of the building blocks are already there: > * we can have image files in an import storage > * we can import image files via the api from such a storage > > this series fills in the missing bits & pieces: > * allow uploading/downloading image files into an import storage via the webgui > * adding the possibility to select such a file when creating a vm/disk > > One minor "ugliness": when switching between import on/off, the target > storage selector resets. This is normally intended by the component, > since it's most often only disabled when it's still visible, except here > in this case. > > If this is a blocker, I can of course add an option to the selector > to not do this here, but IMHO this is a rather odd use case anyway, > so I opted for not handling that explicitely. > > changes from v3: > * allow raw (.raw, .img) and vmdk files too > * automatically append '.raw' for '.img' files > > changes from v2: > * fix correctly unset 'import-from' in wizard when going to summary, > back to disk, unselecting import, then going forward to the summary > again > * fixed an issue with the file selector being mistakenly disabled > > changes from v1: > * fixed an issue where the file selector would be hidden but invalid > > pve-storage: > > Dominik Csapak (1): > import: allow upload of guest images files into import storage > > src/PVE/API2/Storage/Status.pm | 17 ++++++++++++++++- > src/PVE/Storage.pm | 3 ++- > 2 files changed, 18 insertions(+), 2 deletions(-) > > pve-manager: > > Dominik Csapak (3): > ui: storage content: allow upload of guest images for import type > ui: form: file selector: allow optional filter > ui: qemu hd edit: allow importing a disk from the import storage > > www/manager6/form/FileSelector.js | 10 +++ > www/manager6/qemu/HDEdit.js | 71 ++++++++++++++++++++- > www/manager6/window/DownloadUrlToStorage.js | 4 ++ > www/manager6/window/UploadToStorage.js | 7 +- > 4 files changed, 89 insertions(+), 3 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel