From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6E9A4A3AA for ; Mon, 7 Aug 2023 14:05:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E5DF34EDB for ; Mon, 7 Aug 2023 14:05:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 7 Aug 2023 14:05:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E760430B5 for ; Mon, 7 Aug 2023 14:05:34 +0200 (CEST) Message-ID: <9872ffce-d0a6-6028-55fc-746025a5ef58@proxmox.com> Date: Mon, 7 Aug 2023 14:05:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 To: Proxmox VE development discussion , Filip Schauer References: <20230807091829.269932-1-f.schauer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20230807091829.269932-1-f.schauer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -4.139 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu] Add format attributes to function candidates X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2023 12:05:35 -0000 Am 07.08.23 um 11:18 schrieb Filip Schauer: > Add format attributes to functions that take printf-like arguments. This > provides additional compile-time checking that the correct parameters > are passed to the functions. > > This fixes compiler warnings generated by the -Wsuggest-attribute=format > flag. > Which will actually be treated as an error after rebasing to QEMU 8.1, so I already have a change for this lined-up. If you want, you can send a v2 with my suggestion below, otherwise I'll just do the change when rebasing to 8.1. > @@ -177,6 +177,16 @@ index 0000000000..ac1fac6378 > + do { } while (0) > +#endif > + > ++#ifdef __GNUC__ > ++#if __GNUC__ >= 5 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 4) > ++#define PRINTF(i, j) __attribute__((format (gnu_printf, i, j))) > ++#else > ++#define PRINTF(i, j) __attribute__((format (printf, i, j))) > ++#endif > ++#else > ++#define PRINTF(i, j) > ++#endif > ++ Note that QEMU already defines and uses a macro G_GNUC_PRINTF for this, so I'd really like to use that in our patches too, no need to cook up our own :)