From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6FBB67B03B for ; Thu, 7 Jul 2022 10:08:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 65FA21BB1E for ; Thu, 7 Jul 2022 10:08:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 7 Jul 2022 10:08:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 972AE43DE4 for ; Thu, 7 Jul 2022 10:08:52 +0200 (CEST) Message-ID: <9862f60e-3fe7-a072-d4b5-724bc5df529c@proxmox.com> Date: Thu, 7 Jul 2022 10:08:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:103.0) Gecko/20100101 Thunderbird/103.0 Content-Language: en-GB To: Proxmox VE development discussion , Fabian Ebner References: <20220705085239.78671-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220705085239.78671-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] applied: [PATCH v2 manager] ui: restore: improve warning for restoring container with same ID X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 08:08:54 -0000 On 05/07/2022 10:52, Fabian Ebner wrote: > It's not clear to users that the "VM data" includes mount point > volumes including those that are not marked for backup. This is > different from VM restore, where volumes attached at drives not > present in the backup will be kept around as unused volumes. > > Several (supposedly newer) users got tripped up by this over the > years, the latest report being [0]. The long term plan is to make the > restore dialog more flexible to be able to select actions for disks > individually, but that will take a bit of time. In the mean time, make > the warning more explicit. > > [0]: https://forum.proxmox.com/threads/111760/#post-482045 > > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * Text for gettext() is required to be on the same line. > > www/manager6/window/Restore.js | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > applied, but changed the whitespace separator to a newline (
) one in a follow up, thanks!