From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 076966054F for ; Wed, 12 Aug 2020 13:48:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F204110120 for ; Wed, 12 Aug 2020 13:47:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 76E0D10113 for ; Wed, 12 Aug 2020 13:47:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3CACB445B9 for ; Wed, 12 Aug 2020 13:47:55 +0200 (CEST) To: Proxmox VE development discussion , Fabian Ebner References: <20200812114012.7727-1-f.ebner@proxmox.com> From: Stefan Reiter Message-ID: <97dc2b3c-cb57-ec4d-a164-184b7827c508@proxmox.com> Date: Wed, 12 Aug 2020 13:47:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200812114012.7727-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.064 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cpuconfig.pm] Subject: Re: [pve-devel] [PATCH qemu-server] validate_cpu_conf: return config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Aug 2020 11:48:26 -0000 duh, obviously ;) sorry for missing this in my validator series, Reviewed-by: Stefan Reiter if a patch like this even needs it... On 8/12/20 1:40 PM, Fabian Ebner wrote: > as parse_property_string expects it to. > > Signed-off-by: Fabian Ebner > --- > > Found while working on the migration tests. > They already turn out to be useful :) > > PVE/QemuServer/CPUConfig.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm > index 4351cfd..66624fb 100644 > --- a/PVE/QemuServer/CPUConfig.pm > +++ b/PVE/QemuServer/CPUConfig.pm > @@ -191,6 +191,8 @@ sub validate_cpu_conf { > # required, but can't be forced in schema since it's encoded in section > # header for custom models > die "CPU is missing cputype\n" if !$cpu->{cputype}; > + > + return $cpu; > } > PVE::JSONSchema::register_format('pve-vm-cpu-conf', $cpu_fmt, \&validate_vm_cpu_conf); > sub validate_vm_cpu_conf { >