From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 587F9B8B4C for ; Wed, 6 Dec 2023 12:00:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3FA1237DBB for ; Wed, 6 Dec 2023 12:00:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Dec 2023 12:00:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6E46040E8B for ; Wed, 6 Dec 2023 12:00:20 +0100 (CET) Message-ID: <97caa32b-eb4d-434e-965c-b65d51761a41@proxmox.com> Date: Wed, 6 Dec 2023 12:00:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maximiliano Sandoval Cc: Proxmox VE development discussion References: <20231129132117.217210-1-m.sandoval@proxmox.com> <50f3e171-c2b4-4e59-bd7f-07f81b11c0b7@proxmox.com> From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2023 11:00:21 -0000 On 12/6/23 11:21, Maximiliano Sandoval wrote: > > Dominik Csapak writes: > >> translating ACME does not make sense to me since it's >> the name of the protocol and stands for >> Automatic Certificate Management Environment >> >> i don't think/believe this should be translated >> into other languages as a standalone word > > "ACME" appears in four translatable strings, e.g. > > msgid "ACME Accounts" which makes sense since 'accounts' must be translated > > Having the term itself being translatable allows the translator to be > consistent on which term to use when there are multiple translatable > strings containing it. It would be confusing for the user if the only > place where they see "ACME" is in the original string. but that does not change whether ACME is translatable or not. In one case we just 'force' the translator to use it like we intended the translator must make sure the terms are consistent anyway... > > While there are no examples of this specifically for "ACME", there is a > similar one: > > "ACL" is a translatable string which appears in two other translations > > #: proxmox-widget-toolkit/src/window/AuthEditLDAP.js:361 > #: proxmox-widget-toolkit/src/window/SyncWindow.js:110 > #: pve-manager/www/manager6/dc/AuthEditLDAP.js:333 > #: pve-manager/www/manager6/dc/RealmSyncJob.js:355 > #: pve-manager/www/manager6/dc/SyncWindow.js:129 > msgid "ACL" > msgstr "" > > There are at least two languages that actually translate it: > > ru: > msgid "ACL" > msgstr "Список управления доступом" > > ar: > msgid "ACL" > msgstr "قائمة التحكم في الوصول" > > Both translation make use of this in other translations, as shown in the > following translations: > > ru: > msgid "Remove ACLs of vanished users and groups." > msgstr "Удалить списки управления доступом исчезнувших пользователей и групп." > > ar: > msgid "Remove ACLs of vanished users and groups." > msgstr "إزالة قوائم التحكم بالوصول للمستخدمين والمجموعات المختفية." i'd argue that this is different since we use ACL not as a name, but as an abbreviation that might not make sense in other languages (though maybe even that shouldn't be translated...) it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME) that shouldn't change across translations and we removed those gettexts (mostly) a while ago e.g. see lxc/Network.js in pve-manager: ---8<--- boxLabel: 'DHCP', // do not localize --->8--- > > I personally lean towards not translating it, but in my option, that is > a decision that belongs to the translator, having the string be > translatable gives them more context to make this choice. again, we generally don't translate names (dhcp, slaac, ceph, ....) and ACME is just one of these names > > All of this would be simpler if we could extract comments with xgettext > to signal that certain parts of strings should ideally not be > translated. > > Of course, if this is polemic enough, it could be separated into a > different commit/mail-discussion. > > -- > Maximiliano