From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D37F4910AA for ; Fri, 26 Jan 2024 15:47:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B91E637510 for ; Fri, 26 Jan 2024 15:47:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 26 Jan 2024 15:47:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F1F89451B5 for ; Fri, 26 Jan 2024 15:47:35 +0100 (CET) Message-ID: <97b2b802-5e4b-42cc-9623-72fafb7b9495@proxmox.com> Date: Fri, 26 Jan 2024 15:47:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Christoph Heiss References: <20231121094230.309931-1-c.heiss@proxmox.com> From: Fiona Ebner In-Reply-To: <20231121094230.309931-1-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nixos.org, nixos.pm] Subject: Re: [pve-devel] [PATCH container] setup: nixos: set cmode to console by default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2024 14:47:37 -0000 Am 21.11.23 um 10:40 schrieb Christoph Heiss: > In the default NixOS configuration (e.g. when using prebuilt container > images from the Hydra pipeline [0]), getty is only configured for > /dev/console, but not any TTY ports. This results in the user just > getting a blank, black screen when opening the console in the web UI. > > With this, the mentioned tarballs [0] work out-of-the-box. > > [0] https://hydra.nixos.org/job/nixos/trunk-combined/nixos.containerTarball.x86_64-linux > > Signed-off-by: Christoph Heiss > --- > src/PVE/LXC/Setup/NixOS.pm | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/PVE/LXC/Setup/NixOS.pm b/src/PVE/LXC/Setup/NixOS.pm > index c702f3d..7f23111 100644 > --- a/src/PVE/LXC/Setup/NixOS.pm > +++ b/src/PVE/LXC/Setup/NixOS.pm > @@ -17,6 +17,11 @@ sub new { > > $conf->{ostype} = "nixos"; > > + # Set `cmode` to `console` for NixOS containers, as getty is only configured for /dev/console by > + # default, but not any TTY ports. This way, users still get a login/shell instead of just a > + # blank screen when openinng the console in the web UI. > + $conf->{cmode} = 'console'; > + > return bless $self, $class; > } > Won't this override any pre-existing setting (from user or backup)? Even if checking for that, it could still be considered a breaking change, i.e. other people might have configured their NixOS container differently, so maybe best to wait for the next major release? For now, we could log a warning if no explicit 'cmode' was specified for NixOS. I don't see any other implementation of new() overriding any defaults. Should we even start doing that?