From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 6076B1FF150 for ; Mon, 06 Jul 2026 12:23:00 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 772082141D; Mon, 06 Jul 2026 12:22:59 +0200 (CEST) Message-ID: <979b55b7-e9fe-4d6f-b990-46f73d58823c@proxmox.com> Date: Mon, 6 Jul 2026 12:22:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-SERIES storage 0/3] zfspool plugin: fix container rollback and linked clone with refquota=none To: Fiona Ebner , pve-devel@lists.proxmox.com References: <20260706094223.54701-1-f.ebner@proxmox.com> Content-Language: en-US From: Filip Schauer In-Reply-To: <20260706094223.54701-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783333338398 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BLZEABW4CGS4OVZULQ2KCUGT2HUGMD34 X-Message-ID-Hash: BLZEABW4CGS4OVZULQ2KCUGT2HUGMD34 X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 06/07/2026 11:43, Fiona Ebner wrote: > As reported in the community forum [0], rollback of a container with a > ZFS dataset with 'refquota=none' would fail. Similarly, cloning such a > container would fail as well. The reason is that ZFS does not accept a > 0 value for the refquota property, but returns 0 when queried with -p. > > [0]: https://forum.proxmox.com/threads/184113/ > > pve-storage: > > Fiona Ebner (3): > zfspool plugin: fix regression for rollback with refquota=none > zfspool plugin: clone image: use zfs_get_properties() helper > zfspool plugin: clone: fix linked clone of container subvol with > refquota=none > > src/PVE/Storage/ZFSPoolPlugin.pm | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > > Summary over all repositories: > 1 files changed, 4 insertions(+), 5 deletions(-) > With this applied, rolling back to a snapshot with pve-storage:refquota=0 now works and correctly sets refquota=none. Tested-by: Filip Schauer