From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8BD6B1FF13A for ; Wed, 13 May 2026 13:50:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 72D7DA78C; Wed, 13 May 2026 13:50:49 +0200 (CEST) Message-ID: <978e0504-672c-4953-aafa-7634110a47ad@proxmox.com> Date: Wed, 13 May 2026 13:50:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network 1/1] sdn: api: route maps: fix json schema for match, set and exit-action To: Fiona Ebner , pve-devel@lists.proxmox.com References: <20260512134336.312909-1-s.hanreich@proxmox.com> <09f5cf1a-16ec-49d4-a4de-2b412f385988@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <09f5cf1a-16ec-49d4-a4de-2b412f385988@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.612 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2QVMREFC2MGZWGNLDBII5U3SSHBGYG6U X-Message-ID-Hash: 2QVMREFC2MGZWGNLDBII5U3SSHBGYG6U X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/13/26 10:13 AM, Fiona Ebner wrote: > Am 12.05.26 um 3:41 PM schrieb Stefan Hanreich: >> The 2 keys that can have a value in the exit-action both refer to the >> order number of a route map entry, so change the type to the >> pre-defined route map order type. > > ---snip 8<--- > >> @@ -187,11 +189,7 @@ sub route_map_properties { >> 'on-match-goto', 'on-match-next', 'continue', >> ], >> }, >> - value => { >> - type => 'string', >> - optional => 1, >> - description => 'type of exit action', >> - }, >> + value => get_standard_option('pve-sdn-route-map-order'), > > Don't we need an ', { optional => 1 }' here? yes, indeed! https://lore.proxmox.com/pve-devel/09f5cf1a-16ec-49d4-a4de-2b412f385988@proxmox.com/T/#t