From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A30B68582D for ; Mon, 20 Dec 2021 11:31:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A11CE1B21D for ; Mon, 20 Dec 2021 11:31:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 36B3F1B20E for ; Mon, 20 Dec 2021 11:31:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0CE364474D; Mon, 20 Dec 2021 11:31:22 +0100 (CET) Message-ID: <976dac28-05b7-12cb-b534-dfdb9712db93@proxmox.com> Date: Mon, 20 Dec 2021 11:31:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20211216121233.162288-1-f.ebner@proxmox.com> From: Dominik Csapak In-Reply-To: <20211216121233.162288-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.725 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.608 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence Subject: Re: [pve-devel] [PATCH-SERIES storage/manager/guest-common/docs] improvements for protected backups X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 10:31:25 -0000 one question: either it's not explained, or i missed it: what do we gain by having a limit on the number of protected backups? storage 2/2 mentions that protection broke some assumption of vzdump which is (somehow? not really explained imho) fixing it? if it's not fixing it, what is the relation between those things? also, why have a 'magic' -1 value that means indefinite, we could simply always have that behavior? in my opinion, it makes no sense to limit the number of protected backups.. if it is necessary for some reason, it would be good to include that reason either in the commit message, or at least in the cover letter... On 12/16/21 13:12, Fabian Ebner wrote: > The series consists of two parts: > > First part (up to docs 2/2) is for introducing a storage property > to limit the number of protected backups and only count unprotected > backups for the limit check in vzdump. > > Second part is a convenience feature allowing 'protected' and 'notes' > to be set directly with vzdump and for manual backups in the UI. > > > storage: > > Fabian Ebner (2): > list volumes: also return backup type for backups > plugins: allow limiting the number of protected backups per guest > > PVE/Storage.pm | 24 ++++++++++++++++++++++++ > PVE/Storage/BTRFSPlugin.pm | 3 ++- > PVE/Storage/CIFSPlugin.pm | 1 + > PVE/Storage/CephFSPlugin.pm | 1 + > PVE/Storage/DirPlugin.pm | 1 + > PVE/Storage/GlusterfsPlugin.pm | 1 + > PVE/Storage/NFSPlugin.pm | 1 + > PVE/Storage/PBSPlugin.pm | 2 ++ > PVE/Storage/Plugin.pm | 8 ++++++++ > test/list_volumes_test.pm | 10 ++++++++++ > 10 files changed, 51 insertions(+), 1 deletion(-) > > > manager: > > Fabian Ebner (6): > vzdump: backup file list: drop unused parameter > vzdump: backup limit: only count unprotected backups > ui: storage edit: retention: add max-protected-backups setting > ui: storage creation: retention: dynamically adapt > max-protected-backups > vzdump: support setting protected status and notes > ui: backup: allow setting protected and notes for manual backup > > PVE/VZDump.pm | 69 ++++++++++++++++++--------- > www/manager6/panel/BackupJobPrune.js | 71 ++++++++++++++++++++++++---- > www/manager6/storage/Base.js | 1 + > www/manager6/window/Backup.js | 25 +++++++++- > 4 files changed, 132 insertions(+), 34 deletions(-) > > > guest-common: > > Fabian Ebner (1): > vzdump: schema: add 'notes' and 'protected' properties > > src/PVE/VZDump/Common.pm | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > > docs: > > Fabian Ebner (2): > storage: switch to prune-backups in examples > vzdump/storage: mention protected backups limit and give an example > > pve-storage-dir.adoc | 9 +++++---- > pve-storage-pbs.adoc | 2 +- > vzdump.adoc | 3 +++ > 3 files changed, 9 insertions(+), 5 deletions(-) >