From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 364AC7369F for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 14:36:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 222F119D9D for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 14:36:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5DBF219D8F for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 14:36:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 36B0C4588A for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 14:36:00 +0200 (CEST) Message-ID: <96a8a0e5-5049-f989-b984-23fa180c16bf@proxmox.com> Date: Thu, 7 Oct 2021 14:34:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com> References: <20211007104803.40204-1-f.ebner@proxmox.com> <20211007104803.40204-2-f.ebner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20211007104803.40204-2-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.212 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.pm, base.pm, proxmox.com] Subject: [pve-devel] applied: [PATCH container 2/2] setup: also set contents of /etc/timezone X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 07 Oct 2021 12:36:01 -0000 On 07.10.21 12:48, Fabian Ebner wrote: > Some distributions like CentOS 8 and Gentoo don't have the file, so > only update if it already existed. > > A slight change in behavior in set_timezone is that the warning will > now trigger if /etc/localtime is a link to $tz_path, but $tz_path does > not exist. Previously, it would return early if the link matched. > > Programs that rely on /etc/timezone within the container will now see > the configured timezone too. While that is more correct, it's still a > change that might be unexpected. > > Reported in the community forum: > https://forum.proxmox.com/threads/pct-create-command-with-timezone-host-option-fails-to-create-a-container.97538/ > > Signed-off-by: Fabian Ebner <f.ebner@proxmox.com> > --- > > Does this need to wait until PVE 8.0, because of potential breakage? nah, we changed setup stuff all the time, not that frequently anymore because pve-container is quite stable/mature since a while but still here and then. If users report issues with the change we can still adapt to that. > > src/PVE/LXC/Setup.pm | 1 + > src/PVE/LXC/Setup/Base.pm | 16 +++++++++++----- > 2 files changed, 12 insertions(+), 5 deletions(-) > > applied, thanks!