From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 81F987573D for ; Tue, 13 Jul 2021 08:17:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 71EC41C9FB for ; Tue, 13 Jul 2021 08:17:14 +0200 (CEST) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A36891C9E4 for ; Tue, 13 Jul 2021 08:17:12 +0200 (CEST) Received: by mail-wm1-x333.google.com with SMTP id k16-20020a05600c1c90b02901f4ed0fcfe7so1478266wms.5 for ; Mon, 12 Jul 2021 23:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version; bh=4w7hUSgllQUCBV202091e9ZVLYaaBIS0cWtwqGYVSDc=; b=v1k56fdzKShJh74OYZtAZWxpC3ZAyn9VUqDu4XSlt4BQusGNS4zWceYoj3eDBwI7Ud SU38c4j6DEj0ILtSo+Yd2rC7/FlV/GFNtkGIbCkqYybbR/bwDQtHhiOIQ8o5BnezrHBN 0VJA9kq95baWgkdv5fdBBgddNxc7S3RIkj0NZdeM2rXE4gEIuqruDPrxIRIMSND6yXhf DfJDtRyrGn+qS1HhSCX/1GuPx4ywID6Y7y7SxTw/gP1ouYo4/Y6NpYlSZE0YysDqwl64 keu0mXvUG55USMQ9hqGbmLcjusC76wlxyh+MxFT02GzNRbfPSoOcf09nyQ07WSxnrreP 6U7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version; bh=4w7hUSgllQUCBV202091e9ZVLYaaBIS0cWtwqGYVSDc=; b=KPuhAZZGQHBtHOn0RjYYnqxk50U98q72b9Mc0AJzkHrjBas0SOjr7kQqA90261TcOq Y1obx3Hji/ZsD8+Y4bIQvngY1Tcxlo4Fzs14WdIi5CKuWjEU9Bp8KZPx+yRXQjBoz0Vu 0M//rSeZOoKYnJFkEH/Goc9HXdwnO6w6cB6LrV6YSSTlTUtFEXZdVckqRPCEsUoY6ysG oywR67daMyAx42FjaXAJoOjz7VU1QKLzmK9xbAFxaRoQFdgq84hI1zfhtPtheRq6NXXk 9hpUz9LiQ6rqI8TlhkTZoZS3J7BaC/bVavmGppkejlH7Lad3LlvXAQm4tupsHey5+Q5U P/JA== X-Gm-Message-State: AOAM533k7QnPQi5R+WBZN3zDqiNHp2DZViqZkB7RCFuAOKwq7WCOzJE3 QebEf/nnemqP5EYDrmPGWShmlw== X-Google-Smtp-Source: ABdhPJygp5vOjfBr6xvYH3gkLUh1s02qVSChCPwVG+pTIqbGlQSanRr3tKsn1/fenYuUksQLHX8q6g== X-Received: by 2002:a7b:cc15:: with SMTP id f21mr18686757wmh.5.1626157026305; Mon, 12 Jul 2021 23:17:06 -0700 (PDT) Received: from [10.59.100.76] (globalOdiso.M6Lille.odiso.net. [89.248.211.242]) by smtp.gmail.com with ESMTPSA id s17sm16806082wrv.2.2021.07.12.23.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 23:17:05 -0700 (PDT) Message-ID: <961ddec49874e5d20d912588fc21a1da4cf37c8d.camel@odiso.com> From: alexandre derumier To: Thomas Lamprecht , Proxmox VE development discussion Date: Tue, 13 Jul 2021 08:17:05 +0200 In-Reply-To: <6788b7d7-f389-606b-b117-d72b0c585b4d@proxmox.com> References: <20210711224833.66035-1-aderumier@odiso.com> <6788b7d7-f389-606b-b117-d72b0c585b4d@proxmox.com> User-Agent: Evolution 3.40.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.751 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature HTML_MESSAGE 0.001 HTML included in message RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [subnets.pm, vnets.pm] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] [PATCH pve-network] vnet/subnet : add skipdns option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 06:17:14 -0000 Le mardi 13 juillet 2021 à 06:41 +0200, Thomas Lamprecht a écrit : > On 12.07.21 00:48, Alexandre Derumier wrote: > > allow to register ip to ipam without dns registration. > > can be used for temp/pending ip for example > > > > Signed-off-by: Alexandre Derumier > > --- > >  PVE/Network/SDN/Subnets.pm | 70 ++++++++++++++++++++++------------ > > ---- > >  PVE/Network/SDN/Vnets.pm   | 16 ++++----- > >  2 files changed, 49 insertions(+), 37 deletions(-) > > > > looks OK, I wonder if we'd be more future proof if we went for adding > a %param hash > (or as reference with $param) instead, with the skip dns options as > property? > > Not to sure how much change potential there's here. Ok no problem, I'll look for this. (I'm currently reworking lxc ipam too, based on my last work on qemu- server) > > btw., did you checked out newer ifupdown2 already? I saw that > upstream added a changelog > entry already, but not yet tagged as release. > I'm currently testing it. (I had asked to julien to push theses last patches 2 week ago to have them before proxmox7 release, but it was a bit late ^_^) https://github.com/CumulusNetworks/ifupdown2/issues/211 I known they are a dhcp fix, needed by a user on the forum https://github.com/CumulusNetworks/ifupdown2/commit/1eacb76b3ab634838559d3a2b5a4e39b98b21d10 I'll try to finish my tests the week. (I'm going to holiday next week for 3 weeks)