From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2F30391249 for ; Mon, 26 Sep 2022 17:28:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EB27A6456 for ; Mon, 26 Sep 2022 17:28:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 26 Sep 2022 17:28:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D54EF44029 for ; Mon, 26 Sep 2022 17:28:00 +0200 (CEST) Message-ID: <953a9847-4560-495f-6c2f-62f2b1696793@proxmox.com> Date: Mon, 26 Sep 2022 17:27:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 To: Proxmox VE development discussion , Stefan Hanreich References: <20220922141321.1510795-1-s.hanreich@proxmox.com> <20220922141321.1510795-2-s.hanreich@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <20220922141321.1510795-2-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.859 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.766 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-guest-common 1/1] Add abstract methods for pre/post-migrate hooks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2022 15:28:33 -0000 Am 22/09/2022 um 16:13 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > src/PVE/AbstractMigrate.pm | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > for the record, if we do it like this (not much rationale given in the commit message) this breaks containers and qemu-server without such an implementation and needs the respective Breaks/Depends entries in d/control (which you cannot add as you cannot predict the exact version this would get actually added). > diff --git a/src/PVE/AbstractMigrate.pm b/src/PVE/AbstractMigrate.pm > index d90e5b7..5e03488 100644 > --- a/src/PVE/AbstractMigrate.pm > +++ b/src/PVE/AbstractMigrate.pm > @@ -178,6 +178,8 @@ sub migrate { > "public key authentication\n" if $@; > } > > + $self->pre_migration_hooks($self->{vmid}); > + > &$eval_int($self, sub { $self->phase1($self->{vmid}); }); > my $err = $@; > if ($err) { > @@ -228,6 +230,8 @@ sub migrate { > $self->log('err', $err); > $self->{errors} = 1; > } > + > + $self->post_migration_hooks($self->{vmid}); > })}; > > my $err = $@; > @@ -368,4 +372,14 @@ sub get_bwlimit { > return $bwlimit; > } > > +sub pre_migration_hooks { > + my ($self, $vmid) = @_; > + die "abstract method - implement me"; > +} > + > +sub post_migration_hooks { > + my ($self, $vmid) = @_; > + die "abstract method - implement me"; > +} > + > 1;