From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D350A92D13 for ; Wed, 14 Sep 2022 16:15:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BF2172D328 for ; Wed, 14 Sep 2022 16:15:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 14 Sep 2022 16:15:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D1F31441FD for ; Wed, 14 Sep 2022 16:15:10 +0200 (CEST) Message-ID: <94b2d5e7-8770-23a2-e0f4-a54b73d43dec@proxmox.com> Date: Wed, 14 Sep 2022 16:15:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Aaron Lauterer To: Proxmox VE development discussion , Dominik Csapak References: <20220621092012.1776825-1-d.csapak@proxmox.com> <20220621092012.1776825-18-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20220621092012.1776825-18-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.770 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.583 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager v7 07/14] ui: add form/Tag X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2022 14:15:41 -0000 This component seems to not be working as expected. In Firefox (105.0) I get all kinds of glitches and investigating it a bit, it seems like the HTML & CSS classes manipulation doesn't seem to work correctly. For example, if I edit an existing tag and select another existing one from the appearing drop down menu, the tag has a different set of HTML tags than before. The "Add tag" button also seems somewhat broken in that regard, e.g. showing the plus icon more than once. On Chromium (105.0.5195.102), I noticed, that I cannot select a pre-existing tag when adding a new or editing an existing tag, but the tags themselves look okay. I would also recommend that we do test this in Safari and Edge (the officially supported browser). On 6/21/22 11:20, Dominik Csapak wrote: > displays a single tag, with the ability to edit inline on click (when > the mode is set to editable). This brings up a list of globally available tags > for simple selection. > > Also has a mode for adding a new Tag. > > This has a 'layoutCallback' which will be called on input, so that the parent > component can update the layout when the content changes. > This is necessary since we circumvent the extjs logic for updating. > > Signed-off-by: Dominik Csapak > --- > www/manager6/Makefile | 1 + > www/manager6/form/Tag.js | 276 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 277 insertions(+) > create mode 100644 www/manager6/form/Tag.js >