From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 43933BB63C
for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:20:39 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1A9551FBB4
for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:20:09 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:20:07 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 07E3741CE9
for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:20:07 +0100 (CET)
Message-ID: <93fb9823-2b05-4363-8b50-f51f448dd910@proxmox.com>
Date: Mon, 25 Mar 2024 09:20:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Zeidler <a.zeidler@proxmox.com>
References: <20240322135933.164404-1-a.zeidler@proxmox.com>
<20240322135933.164404-6-a.zeidler@proxmox.com>
Content-Language: en-GB
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20240322135933.164404-6-a.zeidler@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.059 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [report.pm]
Subject: Re: [pve-devel] [PATCH manager 6/9] report: switch `dmidecode` to
quiet to omit almost never needed info
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 25 Mar 2024 08:20:39 -0000
On 22/03/2024 14:59, Alexander Zeidler wrote:
> like on this system:
>
> # dmidecode -t bios
> # dmidecode 3.4
> Getting SMBIOS data from sysfs.
> SMBIOS 3.0.0 present.
>
> Handle 0x0000, DMI type 0, 24 bytes
>
> Handle 0x005C, DMI type 13, 22 bytes
The manual page here states that this option also hides other entries:
> Unknown, inactive and OEM-specific entries are not displayed. Meta-data and handle references are hidden.
So especially on newer HW this might contain some actual info beyond
the SMBIOS version/metadata that gets hidden.
I mean, I have no hard feelings here, but I'm wondering if it's really
worth hiding that info if it can include potential relevant stuff.
>
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> PVE/Report.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 505629c7..3a81bdb2 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -104,7 +104,7 @@ my $init_report_cmds = sub {
> hardware => {
> order => 70,
> cmds => [
> - 'dmidecode -t bios',
> + 'dmidecode -t bios -q',
> 'lscpu',
> 'lspci -nnk',
> ],