From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6FEB688FB for ; Wed, 30 Mar 2022 09:14:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 625A84ED1 for ; Wed, 30 Mar 2022 09:14:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 987084EC0 for ; Wed, 30 Mar 2022 09:14:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 43AC542866 for ; Wed, 30 Mar 2022 09:14:27 +0200 (CEST) Message-ID: <93b68514-792f-9513-b7b7-3932fdaf69f5@proxmox.com> Date: Wed, 30 Mar 2022 09:14:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20220328080628.900300-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220328080628.900300-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH container] fix #3960: properly set owner in CT setup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 07:14:31 -0000 On 28.03.22 10:06, Fabian Gr=C3=BCnbichler wrote: > there were two helpers that were not handling this correctly: >=20 > ct_make_path >=20 > since this never gets called with $opts, and there also is no 'owner' > and 'group' in $self, the previous logic could never work, sometimes > leaving nobody:nogroup files around for unprivileged containers. >=20 > since only the centos and suse plugins use this helper, the issue was > fairly limited. >=20 > ct_symlink >=20 > could create symlinks owned by nobody:nogroup. since symlinks are > created 777 by default, this just meant they were not modifiable inside= > the container, but reading/dereferencing was no problem so it went > unnoticed so far. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- >=20 > Notes: > instead of POSIX::lchown we could also expose AT_SYMLINK_NOFOLLOW i= n PVE::Tools > and call fchownat with that, but it would require a versioned dep b= ump.. we can still do that in the future with this patch applied if its really = deemed an improved, and be it just to make it More Nice Code=E2=84=A2. >=20 > src/PVE/LXC/Setup/Base.pm | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) >=20 > applied, thanks!