From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B198369F05 for ; Tue, 15 Mar 2022 08:32:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A0E791B316 for ; Tue, 15 Mar 2022 08:32:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 176C21B30B for ; Tue, 15 Mar 2022 08:32:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E161D42774 for ; Tue, 15 Mar 2022 08:32:00 +0100 (CET) Message-ID: <937a66e6-aa1f-5ef7-5f84-7814f8b6469f@proxmox.com> Date: Tue, 15 Mar 2022 08:31:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, Oguz Bektas References: <20220314135042.1210842-1-o.bektas@proxmox.com> From: Fabian Ebner In-Reply-To: <20220314135042.1210842-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [restenvironment.pm] Subject: Re: [pve-devel] [PATCH v2 common] REST environment: default to root@pam in forked workers if no user was specified X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 07:32:31 -0000 Am 14.03.22 um 14:50 schrieb Oguz Bektas: > first call $rpcenv->get_user() if user was 'undef'. if that doesn't > return then we set it to root@pam. > > Signed-off-by: Oguz Bektas > --- > v1->v2: > * do get_user() first, set to 'root@pam' as fallback > * drop first patch for pve-container (not needed anymore) > > src/PVE/RESTEnvironment.pm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm > index 1b2af08..bc5b8b5 100644 > --- a/src/PVE/RESTEnvironment.pm > +++ b/src/PVE/RESTEnvironment.pm > @@ -492,7 +492,12 @@ sub fork_worker { > $dtype = 'unknown' if !defined ($dtype); > $id = '' if !defined ($id); > > - $user = 'root@pve' if !defined ($user); > + $user = $self->get_user() if !defined($user); If you don't set $noerr when calling get_user(), the below if block is dead code. > + > + if (!defined($user)) { > + warn 'internal error: Worker user was not specified, defaulting to "root@pam"!'; > + $user = 'root@pam'; > + } > > my $sync = ($self->{type} eq 'cli' && !$background) ? 1 : 0; >