From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 60F555BDA0 for ; Wed, 8 Jul 2020 11:50:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4DABE2F8FD for ; Wed, 8 Jul 2020 11:49:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0B13B2F8F1 for ; Wed, 8 Jul 2020 11:49:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C6950401F4 for ; Wed, 8 Jul 2020 11:49:47 +0200 (CEST) To: Stefan Reiter , Proxmox VE development discussion References: <20200708084228.20119-1-s.reiter@proxmox.com> <20200708084228.20119-2-s.reiter@proxmox.com> <14f98570-ca40-9c9a-c7e0-90f53597a91e@proxmox.com> From: Thomas Lamprecht Message-ID: <9353c2a0-daca-4dc8-eb55-2c84157caf52@proxmox.com> Date: Wed, 8 Jul 2020 11:49:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.0 MIME-Version: 1.0 In-Reply-To: <14f98570-ca40-9c9a-c7e0-90f53597a91e@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: Re: [pve-devel] [PATCH qemu-server 2/2] backup: use dirty-bitmap for PBS only if supported by QEMU X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 09:50:19 -0000 On 08.07.20 11:22, Stefan Reiter wrote: > On 7/8/20 11:08 AM, Thomas Lamprecht wrote: >> On 08.07.20 10:42, Stefan Reiter wrote: >>> If 'query-proxmox-support' is not known to QEMU, assume that no other= >>> features are supported either. >>> >>> Signed-off-by: Stefan Reiter >>> --- >>> >>> Does not require any version bumps, since it handles failure graceful= ly. >>> >>> =C2=A0 PVE/VZDump/QemuServer.pm | 6 +++++- >>> =C2=A0 1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm >>> index 567088c..3c2a334 100644 >>> --- a/PVE/VZDump/QemuServer.pm >>> +++ b/PVE/VZDump/QemuServer.pm >>> @@ -443,6 +443,8 @@ sub archive_pbs { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 die "interrupt= ed by signal\n"; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }; >>> =C2=A0 +=C2=A0=C2=A0=C2=A0 my $qemu_support =3D eval { mon_cmd($vmid,= "query-proxmox-support") } // {}; >> >> can we not fall back and instead use undef here to error out with a ni= ce >> "does not support PBS at all" message? >> >=20 > If we want that, sure. Though I think it might be cleaner to also have = a 'pbs' feature as well, I don't like the approach of implicitly detectin= g support just because a QMP command exists. adding an extra command which plainly returns true doesn't changes anythi= ng, at least when done in the initial version of this as then it only can go:= * qmp command exists -> always true * qmp command doesn'T exists -> always false so you do not gain anything by that, but I do not care to much.. >=20 > I'll send a v2. >=20 >>> + >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 my $fs_frozen =3D $self->qga_fs_freeze= ($task, $vmid); >>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 my $params =3D { >>> @@ -453,11 +455,13 @@ sub archive_pbs { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 password =3D> = $password, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 devlist =3D> $= devlist, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'config-file' = =3D> $conffile, >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'use-dirty-bitmap' =3D> J= SON::true, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 $params->{fingerprint} =3D $fingerprin= t if defined($fingerprint); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 $params->{'firewall-file'} =3D $firewa= ll if -e $firewall; >>> =C2=A0 +=C2=A0=C2=A0=C2=A0 $params->{'use-dirty-bitmap'} =3D JSON::tr= ue >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if $qemu_support->{'pbs-d= irty-bitmap'}; >>> + >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 $params->{timeout} =3D 60; # give some= time to connect to the backup server >>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 my $res =3D eval { mon_cmd($vmi= d, "backup", %$params) }; >>> >>