From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7EAE71FF141 for ; Mon, 16 Mar 2026 22:51:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 30A3634D7A; Mon, 16 Mar 2026 22:51:12 +0100 (CET) Message-ID: <9320e19a-94a9-452a-aedd-eea21a0572bf@proxmox.com> Date: Mon, 16 Mar 2026 22:50:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [pve-devel] [PATCH qemu-server v5 8/9] deprecate freeze-fs-on-backup qga setting To: Proxmox VE development discussion , Maximiliano Sandoval References: <20260105121702.20884-1-m.sandoval@proxmox.com> <20260105121702.20884-9-m.sandoval@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260105121702.20884-9-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773697792038 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VK7S23YUZP4LPQZZ3PMO2IJEXCQGTVHD X-Message-ID-Hash: VK7S23YUZP4LPQZZ3PMO2IJEXCQGTVHD X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 05.01.26 um 13:17 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > src/PVE/QemuServer/Agent.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/QemuServer/Agent.pm b/src/PVE/QemuServer/Agent.pm > index 7193d015..05ff4cae 100644 > --- a/src/PVE/QemuServer/Agent.pm > +++ b/src/PVE/QemuServer/Agent.pm > @@ -35,8 +35,10 @@ our $agent_fmt = { > optional => 1, > default => 0, > }, > + # TODO Remove for Proxmox VE 10 > 'freeze-fs-on-backup' => { > - description => "Freeze/thaw guest filesystems on backup for consistency.", > + description => "Deprecated: Use 'guest-fsfreeze' instead.\n\n" > + . " Freeze/thaw guest filesystems on backup for consistency.", > type => 'boolean', > optional => 1, > default => 1, why not just make this an alias for the new (superset) property? And you certainly *cannot* remove this in PVE 10, doing so will break restoring previous backups! This needs some fixing up please.