From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 99B791FF16E
for <inbox@lore.proxmox.com>; Mon, 3 Mar 2025 10:03:37 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 3AA1B5238;
Mon, 3 Mar 2025 10:03:33 +0100 (CET)
Message-ID: <930f1575-c68b-4a59-af11-477ec93b845e@proxmox.com>
Date: Mon, 3 Mar 2025 10:03:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
References: <20250228145022.73966-1-f.ebner@proxmox.com>
<20250228145022.73966-3-f.ebner@proxmox.com>
<c76lrjm3fln5vasd47clrghnzgeqf6xkcj6rdk25g5tvz4wyjb@lxiojhkbujqf>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <c76lrjm3fln5vasd47clrghnzgeqf6xkcj6rdk25g5tvz4wyjb@lxiojhkbujqf>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.294 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence
Subject: Re: [pve-devel] [PATCH storage 2/6] btrfs: fix volume size info for
subvolumes in scalar context
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: pve-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Am 03.03.25 um 08:31 schrieb Wolfgang Bumiller:
> On Fri, Feb 28, 2025 at 03:50:18PM +0100, Fiona Ebner wrote:
>> Return the same size as in list context. See also commit "plugin: file
>> size info: be consistent about size of directory subvol".
>>
>> Fixes cloning containers with unsized subvolumes on BTRFS. Before the
>> change, this would fail with "mkfs.ext4: Device size reported to be
>> zero.".
>
> Interesting how it says "reported to be zero", when this commit changes
> it from `1` to, well, zero?
When allocating the volume for the clone, we use the same size as the
old volume. The value 0 will lead to using 'subvol' format for the new
volume. With 1, it tries to use 'raw' format and then fails when
attempting to format.
>
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>> src/PVE/Storage/BTRFSPlugin.pm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm
>> index 1966b6f..b1f7912 100644
>> --- a/src/PVE/Storage/BTRFSPlugin.pm
>> +++ b/src/PVE/Storage/BTRFSPlugin.pm
>> @@ -486,7 +486,7 @@ sub volume_size_info {
>> my $ctime = (stat($path))[10];
>> my ($used, $size) = (0, 0);
>> #my ($used, $size) = btrfs_subvol_quota($class, $path); # uses wantarray
>> - return wantarray ? ($size, 'subvol', $used, undef, $ctime) : 1;
>> + return wantarray ? ($size, 'subvol', $used, undef, $ctime) : $size;
>> }
>>
>> return PVE::Storage::Plugin::file_size_info($path, $timeout, $format);
>> --
>> 2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel