From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 7293E1FF16E
for <inbox@lore.proxmox.com>; Mon, 17 Feb 2025 09:58:22 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 641DD1A1EE;
Mon, 17 Feb 2025 09:58:18 +0100 (CET)
Message-ID: <92bb8b7a-2ce8-4ed6-ab10-39bc10d754b1@proxmox.com>
Date: Mon, 17 Feb 2025 09:58:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Abraham <a.abraham@proxmox.com>
References: <20250206122011.18561-1-a.abraham@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20250206122011.18561-1-a.abraham@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.021 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-access-control] fix #5076: Added the
"aud" field to the configuration and API schemas
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 2/6/25 13:20, Alexander Abraham wrote:
> Added a field for OpenID audiences to the JSON schema
> and retrieved the data for the audiences the user
> configured on the frontend.
Hi,
same comment as for the last patch:
please don't write the 'what'/'how' here, but rather the 'why'
e.g. 'We want to let users specify the audiences to verify [...]'
some comments inline
>
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
> src/PVE/API2/OpenId.pm | 5 ++++-
> src/PVE/Auth/OpenId.pm | 6 ++++++
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/OpenId.pm b/src/PVE/API2/OpenId.pm
> index 77410e6..ad92fcb 100644
> --- a/src/PVE/API2/OpenId.pm
> +++ b/src/PVE/API2/OpenId.pm
> @@ -45,6 +45,10 @@ my $lookup_openid_auth = sub {
> $openid_config->{acr_values} = [ PVE::Tools::split_list($acr) ];
> }
>
> + if (defined(my $aud = $config->{'aud'})) {
> + $openid_config->{aud} = [ PVE::Tools::split_list($aud) ];
> + }
> +
you do a split list here
> my $openid = PVE::RS::OpenId->discover($openid_config, $redirect_url);
> return ($config, $openid);
> };
> @@ -169,7 +173,6 @@ __PACKAGE__->register_method ({
> my $redirect_url = extract_param($param, 'redirect-url');
>
> my ($config, $openid) = $lookup_openid_auth->($realm, $redirect_url);
> -
> my $info = $openid->verify_authorization_code($param->{code}, $private_auth_state);
> my $subject = $info->{'sub'};
>
> diff --git a/src/PVE/Auth/OpenId.pm b/src/PVE/Auth/OpenId.pm
> index c8e4db9..a7af1bc 100755
> --- a/src/PVE/Auth/OpenId.pm
> +++ b/src/PVE/Auth/OpenId.pm
> @@ -63,6 +63,11 @@ sub properties {
> pattern => '^[^\x00-\x1F\x7F <>#"]*$', # Prohibit characters not allowed in URI RFC 2396.
> optional => 1,
> },
> + 'aud' => {
> + description => "Specifies the Authentication claims neccessary for checking the privileges the requesting user has.",
> + type => 'string',
> + optional => 1,
> + },
but here you don't mention that it's actually a list
also there is no limit on what users can enter, normally we are rather strict with that
(e.g. just allow [a-zA-Z0-9_+.] etc.)
it's better to be strict first since we can always loosen the requirements later.
when we accept everything it's much harder to get more strict later
also, i don't think 'aud' is the best way to name this field. what about 'audiences' ?
> };
> }
>
> @@ -76,6 +81,7 @@ sub options {
> prompt => { optional => 1 },
> scopes => { optional => 1 },
> "acr-values" => { optional => 1 },
> + "aud" => { optional => 1 },
> default => { optional => 1 },
> comment => { optional => 1 },
> };
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel