From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3AD4C1FF141 for ; Tue, 19 May 2026 18:01:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9DA25D33C; Tue, 19 May 2026 18:00:57 +0200 (CEST) Message-ID: <9218cd8a-5ba8-455b-8d15-50b65fef7bcd@proxmox.com> Date: Tue, 19 May 2026 18:00:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-SERIES ha-manager 0/2] make idle LRMs resolve leftover moving HA resources while disarmed To: Daniel Kral , pve-devel@lists.proxmox.com References: <20260519143842.382324-1-d.kral@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779206410108 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JDLAZGSSONOINIHZKMA6HJ5IWI6CYQGD X-Message-ID-Hash: JDLAZGSSONOINIHZKMA6HJ5IWI6CYQGD X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 19.05.26 um 4:47 PM schrieb Daniel Kral: > On Tue May 19, 2026 at 4:38 PM CEST, Daniel Kral wrote: >> As in patch message #2: >> >> If there are HA resources, which are in transient states that defer the >> disarming process, but their LRMs are already in idle state and disarmed >> mode, these LRMs will not properly resolve the transient states of these >> HA resources as assumed by the HA Manager. >> >> For HA resources, which are still moving, this makes the HA Manager >> stuck in a loop, which tries to defer the disarming process to wait for >> a LRM response for these moving HA resources, which will never come as >> the LRM is idle. >> >> Therefore allow the LRM to become active in disarm mode if there are any >> HA resources on the LRM's node, which are in any of these transient >> states, and make sure that the LRM only processes the disarm-deferring >> HA resources while the LRM is active. > > Sorry, forgot to add a this trailer to the series (can b4 pickup these > trailers as well?): > > Reported-by: Max R. Carrara Yes, but only with an extra commandline option: NOTE: some trailers ignored due to from/email mismatches: ! Trailer: Reported-by: Max R. Carrara Msg From: Daniel Kral NOTE: Rerun with -S to apply them anyway and it would order them after your S-o-B. FWIW, the patches look good to me otherwise, but see my reply to 2/2 for some nits: Reviewed-by: Fiona Ebner