From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C91B21FF145 for ; Thu, 22 Jan 2026 16:25:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CDC1A1A380; Thu, 22 Jan 2026 16:25:59 +0100 (CET) Message-ID: <91e967d8-fe7a-4588-bc72-bf3b5074cbe3@proxmox.com> Date: Thu, 22 Jan 2026 16:25:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Dominik Csapak References: <20251212074419.275374-1-d.csapak@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251212074419.275374-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769095468345 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 12.12.25 um 08:44 schrieb Dominik Csapak: > the resource store has a field 'diskuse' which it calculates on update. > Use that instead of calculating the value ourselves everytime. > > For change detection, we only need a resolution of 0.01 (since we want > to use the percentage as integer) so check that the difference of old and new > is bigger than 0.9% . > > This works because we only overwrite the values in the treestore if > anything changed, so multiple small changes to the diskuse will not be > lost. > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * improve commmit message to note why many small changes are not lost > * use `>= 0.01` instead of `> 0.009` > > www/manager6/tree/ResourceTree.js | 27 ++++++++++++++++++--------- > 1 file changed, 18 insertions(+), 9 deletions(-) > > diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js > index bb016f8c..b0e094f1 100644 > --- a/www/manager6/tree/ResourceTree.js > +++ b/www/manager6/tree/ResourceTree.js > @@ -409,14 +407,25 @@ Ext.define('PVE.tree.ResourceTree', { > } > } > > - // tree item has been updated > - for (const field of changedFields) { > - if (item.data[field] !== olditem.data[field]) { > + let diskuse = item.data.diskuse; While the API is hard to change, we could still use a bit more telling variable names, like diskUsage and oldDiskUsage. Just a not, and if I would not had noticed below tiny potential bug, I might have just fixed this up locally. > + let oldDiskuse = olditem.data.diskuse; > + > + if (diskuse !== undefined || oldDiskuse !== undefined) { > + if (Math.abs(diskuse - oldDiskuse) >= 0.01) { this is never true vor the case where one is defined and the other value is undefined though, as the result then is NaN. But, when old is undefined and new isn't we probably always want to trigger a change event? Might be enough to add a extra branch like: } else if (typeof diskUsage !== typeof oldDiskUsage) { changed = true; } > changed = true; > - break; > } > } > - // FIXME: also test filterfn()? > + > + if (!changed) { > + // tree item has been updated > + for (const field of changedFields) { > + if (item.data[field] !== olditem.data[field]) { > + changed = true; > + break; > + } > + } > + // FIXME: also test filterfn()? > + } > } > > if (changed) { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel