From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 59F7C1FF166 for ; Fri, 11 Oct 2024 15:01:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2525E3D9B6; Fri, 11 Oct 2024 15:01:45 +0200 (CEST) Message-ID: <91ca7cbd-3f14-484b-82f7-052d3a5d8eae@proxmox.com> Date: Fri, 11 Oct 2024 15:01:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Mira Limbeck References: <20241011093744.25545-1-f.weber@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage] iscsi: disable Open-iSCSI login retries to avoid blocking pvestatd X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thanks for the test and review! On 11/10/2024 13:20, Mira Limbeck wrote: > [...] >> --- a/src/PVE/Storage/ISCSIPlugin.pm >> +++ b/src/PVE/Storage/ISCSIPlugin.pm >> @@ -132,6 +132,14 @@ sub iscsi_login { >> eval { iscsi_discovery($portals); }; >> warn $@ if $@; >> >> + # Disable retries to avoid blocking pvestatd for too long, next iteration will retry anyway >> + eval { >> + my $cmd = [$ISCSIADM, '--mode', 'node', '--targetname', $target, '--op', 'update', >> + '--name', 'node.session.initial_login_retry_max', '--value', '0']; > As shortly discussed off-list, this should probably follow a similar > style as the `Wrapping Arguments` section in the Perl Style Guide, but > grouping option and value together in the same line? > https://pve.proxmox.com/wiki/Perl_Style_Guide#Wrapping_Arguments Good point. I sent a v2 addressing this (and also rewording the commit message, because I realized the v1 one was not really correct): https://lore.proxmox.com/pve-devel/20241011125821.58224-1-f.weber@proxmox.com/ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel