From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A2E2871ABD for ; Tue, 5 Oct 2021 07:36:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 934BF235CB for ; Tue, 5 Oct 2021 07:35:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 23321235BD for ; Tue, 5 Oct 2021 07:35:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EAB5A455F6 for ; Tue, 5 Oct 2021 07:35:33 +0200 (CEST) Message-ID: <91bec9a1-9b85-3cd0-08b7-9c7196a9acb8@proxmox.com> Date: Tue, 5 Oct 2021 07:34:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion , Stefan Reiter References: <20211004152921.2839809-1-s.reiter@proxmox.com> <20211004152921.2839809-4-s.reiter@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211004152921.2839809-4-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.226 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v3 manager 3/3] ui: add support for adding TPM devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 05:36:04 -0000 On 04.10.21 17:29, Stefan Reiter wrote: > Inspired by HDEfi for efidisks. Extends the DiskStorageSelector to allow > hiding the format, since tpmstate can only be stored in 'raw' format > (even on directory storages). > > Signed-off-by: Stefan Reiter > --- > www/manager6/Makefile | 1 + > www/manager6/Utils.js | 2 +- > www/manager6/form/DiskStorageSelector.js | 5 +- > www/manager6/qemu/HDMove.js | 1 + > www/manager6/qemu/HDTPM.js | 88 ++++++++++++++++++++++++ > www/manager6/qemu/HardwareView.js | 25 ++++++- > 6 files changed, 119 insertions(+), 3 deletions(-) > create mode 100644 www/manager6/qemu/HDTPM.js > > applied, thanks! But I'm once again remebered that the sepcial disk like efidisk and now tpmstate are really weird when being removed, as they get marked as unused disk and when one tries to re-attach them they'll act like they really are a disk. But, this is nothing new and its the dropping of information is also a nuisance for "real" disks, if one has properties set like bus, wwn, ... they're all lost and re-attaching means recreating all of them, if we'd try to save as much as possible of those things for unused disks too we could allow to prefill that information on the re-attach dialogue and also differ between normal disks and special disks like efi or tpm here. but that's for another seires ;)