From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7591D1FF141 for ; Tue, 05 May 2026 11:15:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E9DD20C0F; Tue, 5 May 2026 11:15:11 +0200 (CEST) Message-ID: <91485fe4-8bf1-4cff-a9b4-7fe460b35eb5@proxmox.com> Date: Tue, 5 May 2026 11:14:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network v4 32/47] sdn: change detection for route maps / prefix lists To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260504160350.395470-1-s.hanreich@proxmox.com> <20260504160350.395470-33-s.hanreich@proxmox.com> <2699f5da-35e9-4965-b031-7899d5cb9d93@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <2699f5da-35e9-4965-b031-7899d5cb9d93@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.506 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DYVIKYI4URJIDX5U2GVS4GXUQSM7BURG X-Message-ID-Hash: DYVIKYI4URJIDX5U2GVS4GXUQSM7BURG X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/5/26 11:06 AM, Hannes Laimer wrote: > On 2026-05-04 18:04, Stefan Hanreich wrote: >> Add both configuration files to the has_pending_changes function, in >> order to detect changes to the global SDN configuration. Additionally, >> some new keys that are not primitive types have been introduced in the >> route-maps.cfg and prefix-lists.cfg. Add them to the function that >> generates the pending changes in the SDN stack, so we can return them >> from the respective endpoints. >> >> Signed-off-by: Stefan Hanreich >> --- >> src/PVE/Network/SDN.pm | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm >> index 0bb36bf..ab97a59 100644 >> --- a/src/PVE/Network/SDN.pm >> +++ b/src/PVE/Network/SDN.pm >> @@ -241,6 +241,8 @@ sub has_pending_changes { >> vnets => PVE::Network::SDN::Vnets::config(), >> subnets => PVE::Network::SDN::Subnets::config(), >> controllers => PVE::Network::SDN::Controllers::config(), >> + 'route-maps' => PVE::Network::SDN::RouteMaps::config(), >> + 'prefix-lists' => PVE::Network::SDN::PrefixLists::config(), > > > we need `->to_sections()` for these two, perlmod returns a blessed but > empty hash, so once route-maps or prefix-lists exist in the running > config change detection sees them all as deleted > > > could reproduce this with: > ``` > pvesh create /cluster/sdn/prefix-lists --id reprolist --entries > 'action=permit,prefix=192.0.2.0/24' > > pvesh set /cluster/sdn > > pvesh create /cluster/sdn/lock >> could not acquire lock for SDN config: configuration has pending > changes at /usr/share/perl5/PVE/API2/Network/SDN.pm line 164. > ``` makes sense, will fix this in the next iteration!