From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 21BF391058 for ; Fri, 26 Jan 2024 12:15:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF6223455E for ; Fri, 26 Jan 2024 12:15:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 26 Jan 2024 12:15:00 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9F731492DB for ; Fri, 26 Jan 2024 12:15:00 +0100 (CET) Message-ID: <9144bf1e-cbb1-416b-a0e1-59c0a07d389b@proxmox.com> Date: Fri, 26 Jan 2024 12:14:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Friedrich Weber References: <20240111150332.733635-1-f.weber@proxmox.com> <20240111150332.733635-2-f.weber@proxmox.com> From: Fiona Ebner In-Reply-To: <20240111150332.733635-2-f.weber@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, lvmplugin.pm] Subject: Re: [pve-devel] [PATCH storage 1/2] lvm: ignore "activation skip" LV flag during LV activation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2024 11:15:33 -0000 Am 11.01.24 um 16:03 schrieb Friedrich Weber: > LVs with the "activation skip" flag (can be set via `lvchange -ky`) > are only activated if `-K` is passed to the activation command. In the > next major release, we intend to set the "activation skip" flag for > newly created LVs. The goal is to prevent LVs from being > auto-activated after boot, and thus fix bug #4997. > > In preparation for this future change, adjust activation commands > issued by the LVM plugin to include the `-K` flag. For LVs without the > "activation skip" flag, passing the `-K` flag during activation has no > effect, so it should be harmless to always provide it. > > [1] https://bugzilla.proxmox.com/show_bug.cgi?id=4997 > > Suggested-by: Fabian Grünbichler > Signed-off-by: Friedrich Weber Reviewed-by: Fiona Ebner > --- > src/PVE/Storage/LVMPlugin.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm > index 4b951e7..66b42de 100644 > --- a/src/PVE/Storage/LVMPlugin.pm > +++ b/src/PVE/Storage/LVMPlugin.pm > @@ -342,7 +342,7 @@ sub lvcreate { > $size .= "k"; # default to kilobytes > } > > - my $cmd = ['/sbin/lvcreate', '-aly', '-Wy', '--yes', '--size', $size, '--name', $name]; > + my $cmd = ['/sbin/lvcreate', '-aly', '-K', '-Wy', '--yes', '--size', $size, '--name', $name]; Style nit: line too long > for my $tag (@$tags) { > push @$cmd, '--addtag', $tag; > }