From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id E780D1FF13B
	for <inbox@lore.proxmox.com>; Wed, 11 Mar 2026 16:59:01 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 7D49632555;
	Wed, 11 Mar 2026 16:58:39 +0100 (CET)
Message-ID: <90cc5f1b-03b6-48dd-b15a-4afa93111070@proxmox.com>
Date: Wed, 11 Mar 2026 16:58:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH manager 6/7] ui: qga: call parameter me instead of this
To: Maximiliano Sandoval <m.sandoval@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260225154614.681858-1-m.sandoval@proxmox.com>
 <20260225154614.681858-7-m.sandoval@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20260225154614.681858-7-m.sandoval@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1773244649442
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.002 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: ZOWWM3K75AOTUQOLV2ZEZTKCA6PZUCI4
X-Message-ID-Hash: ZOWWM3K75AOTUQOLV2ZEZTKCA6PZUCI4
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 25.02.26 um 4:46 PM schrieb Maximiliano Sandoval:
> This is how it is generally done, we will use `me` in the next commit.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

There is also a lot of code using this.something directly and we don't
have something written about this in the JavaScript style guide, so I
wouldn't mind either way:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
>  www/manager6/form/AgentFeatureSelector.js | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
> index a3dda630..1a87182d 100644
> --- a/www/manager6/form/AgentFeatureSelector.js
> +++ b/www/manager6/form/AgentFeatureSelector.js
> @@ -104,6 +104,8 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>      },
>  
>      setValues: function (values) {
> +        let me = this;
> +
>          let res = PVE.Parser.parsePropertyString(values.agent, 'enabled');
>          if (!Ext.isDefined(res['freeze-fs-on-backup'])) {
>              res['freeze-fs-on-backup'] = 1;
> @@ -112,6 +114,6 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>              res['guest-fsfreeze'] = 1;
>          }
>  
> -        this.callParent([res]);
> +        me.callParent([res]);
>      },
>  });