From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 179861FF168 for ; Tue, 12 Nov 2024 10:17:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4702D1B91A; Tue, 12 Nov 2024 10:17:15 +0100 (CET) Message-ID: <907f5afc-f581-4e9b-892e-d5d0f5f464f2@proxmox.com> Date: Tue, 12 Nov 2024 10:16:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Timothy Nicholson References: <20241111113519.118949-1-t.nicholson@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20241111113519.118949-1-t.nicholson@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] fix #5847: ui: gettextize several strings in ui X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" one comment inline On 11/11/24 12:35, Timothy Nicholson wrote: > Several strings that should probably also be translated now use > the gettext function to be translated. > > Signed-off-by: Timothy Nicholson > --- > [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5847 > > www/manager6/Workspace.js | 2 +- > www/manager6/ceph/OSD.js | 6 +++--- > www/manager6/ceph/OSDDetails.js | 2 +- > www/manager6/form/VMCPUFlagSelector.js | 24 ++++++++++++------------ > www/manager6/qemu/ProcessorEdit.js | 2 +- > www/manager6/window/Settings.js | 6 +++--- > 6 files changed, 21 insertions(+), 21 deletions(-) > > diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js > index 52c66108..56dde151 100644 > --- a/www/manager6/Workspace.js > +++ b/www/manager6/Workspace.js > @@ -388,7 +388,7 @@ Ext.define('PVE.StdWorkspace', { > }, > }, > { > - text: 'TFA', > + text: gettext('TFA'), is it a good idea to translate this? it's mostly a technical term (which we generally don't translate), but i'd be swayed if there is an actual example where a language want to have that translated... _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel