From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 0DF181FF176
	for <inbox@lore.proxmox.com>; Fri,  7 Mar 2025 12:20:35 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 09D9F19636;
	Fri,  7 Mar 2025 12:20:28 +0100 (CET)
Message-ID: <905fc7b1-9bf7-4ad1-8a0f-c96b6e539832@proxmox.com>
Date: Fri, 7 Mar 2025 12:20:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Dominik Csapak <d.csapak@proxmox.com>
References: <20250213131716.3062383-1-d.csapak@proxmox.com>
 <20250213131716.3062383-9-d.csapak@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20250213131716.3062383-9-d.csapak@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -1.042 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 KAM_MAILER                  2 Automated Mailer Tag Left in Email
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [pci.pm]
Subject: Re: [pve-devel] [PATCH qemu-server v6 05/10] pci: set
 'enable-migration' to on for live-migration marked mapped devices
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Am 13.02.25 um 14:17 schrieb Dominik Csapak:
> the default is 'auto', but for those which are marked as capable for
> live migration, we want to explicitly enable that, so we get an early
> error on start if the driver does not support that.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
> no changes in v6
>  PVE/QemuServer/PCI.pm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
> index a0d99692..6bde248b 100644
> --- a/PVE/QemuServer/PCI.pm
> +++ b/PVE/QemuServer/PCI.pm
> @@ -433,9 +433,11 @@ sub parse_hostpci {
>  	die "PCI device mapping not found for '$mapping'\n" if !$devices || !scalar($devices->@*);
>  
>  	my $config = PVE::Mapping::PCI::config();
> +	my $cfg = $config->{ids}->{$mapping};

Style nit: bit confusing to have such similarly named variables

> +	$res->{'live-migration-capable'} = 1 if $cfg->{'live-migration-capable'};
>  
>  	for my $device ($devices->@*) {
> -	    eval { PVE::Mapping::PCI::assert_valid($mapping, $device, $config->{ids}->{$mapping}) };
> +	    eval { PVE::Mapping::PCI::assert_valid($mapping, $device, $cfg) };
>  	    die "PCI device mapping invalid (hardware probably changed): $@\n" if $@;
>  	    push $alternatives->@*, [split(/;/, $device->{path})];
>  	}
> @@ -692,6 +694,10 @@ sub print_hostpci_devices {
>  		$devicestr .= ",host=$pcidevice->{id}";
>  	    }
>  
> +	    if ($d->{'live-migration-capable'}) {
> +		$devicestr .= ",enable-migration=on"

Style nit: missing semicolon

> +	    }
> +
>  	    my $mf_addr = $multifunction ? ".$j" : '';
>  	    $devicestr .= ",id=${id}${mf_addr}${pciaddr}${mf_addr}";
>  



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel