From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2D9976A214 for ; Thu, 4 Mar 2021 09:05:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1A595F192 for ; Thu, 4 Mar 2021 09:04:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4F77EF184 for ; Thu, 4 Mar 2021 09:04:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1DD744583A for ; Thu, 4 Mar 2021 09:04:44 +0100 (CET) To: Thomas Lamprecht , Proxmox VE development discussion References: <20210303110128.9244-1-f.ebner@proxmox.com> <20210303110128.9244-2-f.ebner@proxmox.com> <38c2b48c-241a-67e6-c88e-7fe69a0cd7d7@proxmox.com> From: Fabian Ebner Message-ID: <902a59fa-0406-8427-8825-5de95cd9805f@proxmox.com> Date: Thu, 4 Mar 2021 09:04:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <38c2b48c-241a-67e6-c88e-7fe69a0cd7d7@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 1/4] vmstatus: make boolean value explicit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2021 08:05:16 -0000 Am 03.03.21 um 17:53 schrieb Thomas Lamprecht: > On 03.03.21 12:01, Fabian Ebner wrote: >> as otherwise the empty string is printed with 'qm status --verbose' when >> it's not a template. >> >> Signed-off-by: Fabian Ebner >> --- >> PVE/QemuServer.pm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm >> index a498444..43d7c6b 100644 >> --- a/PVE/QemuServer.pm >> +++ b/PVE/QemuServer.pm >> @@ -2621,7 +2621,7 @@ sub vmstatus { >> $d->{diskread} = 0; >> $d->{diskwrite} = 0; >> >> - $d->{template} = PVE::QemuConfig->is_template($conf); >> + $d->{template} = PVE::QemuConfig->is_template($conf) ? 1 : 0; > > > Any reason to not do: > > $d->{template} = 1 if PVE::QemuConfig->is_template($conf); > > (no hard feelings, but this is relatively common pattern for such things, > especially if they can be normally more often omitted than not, templates > are normally rather outnumbered by non-templates) > Not really a reason, just that the key was always present before the change too. But it's not an API return key, so making this optional is no problem at all (and we do so for other ones like the 'serial' below, so it's also more consistent in a way). I'll send a v2. >> >> $d->{serial} = 1 if conf_has_serial($conf); >> $d->{lock} = $conf->{lock} if $conf->{lock}; >> >