From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 4E51D60976
 for <pve-devel@lists.proxmox.com>; Sat,  6 Feb 2021 15:12:32 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 4C53411E8B
 for <pve-devel@lists.proxmox.com>; Sat,  6 Feb 2021 15:12:32 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 31CB211E7D
 for <pve-devel@lists.proxmox.com>; Sat,  6 Feb 2021 15:12:28 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EE0A541B7A;
 Sat,  6 Feb 2021 15:12:27 +0100 (CET)
Message-ID: <900ce873-7064-8700-6ccd-fa7a42998b55@proxmox.com>
Date: Sat, 6 Feb 2021 15:12:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101
 Thunderbird/86.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Alexandre Derumier <aderumier@odiso.com>
References: <20201104014205.1369213-1-aderumier@odiso.com>
 <20201104014205.1369213-2-aderumier@odiso.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20201104014205.1369213-2-aderumier@odiso.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.009 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.105 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure
 stats
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Sat, 06 Feb 2021 14:12:32 -0000

sorry for the late reply!

On 04.11.20 02:42, Alexandre Derumier wrote:
> ---
>  src/PVE/LXC.pm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 5cfcf28..ad1460c 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -291,6 +291,24 @@ sub vmstatus {
>  	} else {
>  	    $d->{cpu} = 0;
>  	}
> +
> +	if (defined(my $pressure = $cgroups->get_pressure_stat())) {
> +	    $d->{pressure} = $pressure;
> +	} else {
> +	    $d->{pressure} = {
> +		cpu => {
> +		    some => { avg10 => 10, avg60 => 0, avg300 => 0 }

Setting avg10 to 10 seems wrong?


> +		},
> +		memory => {
> +		    some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> +		    full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> +		},
> +		io => {
> +		    some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> +		    full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> +		},
> +	    };
> +	}
>      }
>  
>      my $netdev = PVE::ProcFSTools::read_proc_net_dev();
>