From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1E05192310 for ; Fri, 16 Feb 2024 16:56:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 01FA75CD9 for ; Fri, 16 Feb 2024 16:56:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Feb 2024 16:56:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3976F48550 for ; Fri, 16 Feb 2024 16:56:47 +0100 (CET) Message-ID: <8fa0d233-67fe-4bb3-95f9-aa0f24b19a29@proxmox.com> Date: Fri, 16 Feb 2024 16:56:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Philipp Hufnagl References: <20231127114001.189590-1-p.hufnagl@proxmox.com> <20231127114001.189590-3-p.hufnagl@proxmox.com> From: Fiona Ebner In-Reply-To: <20231127114001.189590-3-p.hufnagl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH storage v4 2/4] pbs: Make it possible to reuse PBS connection for datastore API call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2024 15:56:48 -0000 Am 27.11.23 um 12:39 schrieb Philipp Hufnagl: > It would be nice to reuse an existing PBS connection for scan_datastore. > Because scan_datastore is used multiple in the code, it can not be > changed without breaking existing code. > I'm no fan of the second sentence. You do change it with the patch without breaking existing code ;) I'd rather just mention that this is in preparation for a call site where the connection will be re-used. > This change add an optional connection parameter to scan_datastore. If > it is passed it will use this connection. If not, it will create a new > one. > > Signed-off-by: Philipp Hufnagl > --- > src/PVE/Storage/PBSPlugin.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm > index 96373a4..b4d7914 100644 > --- a/src/PVE/Storage/PBSPlugin.pm > +++ b/src/PVE/Storage/PBSPlugin.pm > @@ -808,9 +808,9 @@ sub status { > # fingerprint (optional for trusted certs) > # } > sub scan_datastores { > - my ($scfg, $password) = @_; > + my ($scfg, $password, $conn) = @_; > > - my $conn = pbs_api_connect($scfg, $password); > + $conn = pbs_api_connect($scfg, $password) if !defined($conn); > Style nit: using '//=' would be slightly shorter/more straightforward. > my $response = eval { $conn->get('/api2/json/admin/datastore', {}) }; > die "error fetching datastores - $@" if $@;